Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Svelte 4.x as peerDependency in package.json #71

Open
fmaclen opened this issue Nov 10, 2023 · 1 comment
Open

Set Svelte 4.x as peerDependency in package.json #71

fmaclen opened this issue Nov 10, 2023 · 1 comment
Labels
1.0 Features that introduce breaking changes and require version bump triage Issues that are being looked into

Comments

@fmaclen
Copy link
Owner

fmaclen commented Nov 10, 2023

Reverted from 4.x to 3.x in #70

Making this change means that we can no longer support types in Svelte 3.x which would be a breaking change.
@fmaclen fmaclen added the 1.0 Features that introduce breaking changes and require version bump label Nov 10, 2023
@fmaclen
Copy link
Owner Author

fmaclen commented Nov 11, 2023 •
edited
Loading

Or maybe not.

peerDependency was set by the SvelteKit skeleton package generator. I added it this project here, but then it caused issues. This was later removed and so far it has not been a problem.

The library doesn't require (so far) any specific versions of Svelte so demanding a specific version as a peer dependency doesn't seem to be worth it.

@fmaclen fmaclen added the triage Issues that are being looked into label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 Features that introduce breaking changes and require version bump triage Issues that are being looked into
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmaclen