Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Flyteadmin support for sqlite3 #2138

Open
2 tasks done
kumare3 opened this issue Feb 6, 2022 · 6 comments
Open
2 tasks done

[Core feature] Flyteadmin support for sqlite3 #2138

kumare3 opened this issue Feb 6, 2022 · 6 comments
Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service stale

Comments

@kumare3
Copy link
Contributor

kumare3 commented Feb 6, 2022

Motivation: Why do you think this is important?

Currently to start sandbox flyteadmin needs a postgres server. GORM supports sqlite3 and this should be possible to use with flyteadmin

GORM support: https://gorm.io/docs/connecting_to_the_database.html#SQLite

Goal: What should the final outcome look like, ideally?

if i start flyteadmin locally, it should be possible to start with a sqlite db . This would speed up testing and starting up of flyteadmin.
Similarly we can do the same for datacatalog

Describe alternatives you've considered

start a postgres server

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@kumare3 kumare3 added enhancement New feature or request flyteadmin Issue for FlyteAdmin Service labels Feb 6, 2022
@NikeNano
Copy link

I would be happy to work on this, will start to take a look at it.

@kumare3
Copy link
Contributor Author

kumare3 commented Sep 9, 2022

The database can be set to sqlite3 using

database:
  sqlite:
    file: admin.db

And the best way to work on this is to use the single binary development
the local config is here -

database:
postgres:
port: 30089
username: postgres
host: localhost
dbname: flyteadmin
options: "sslmode=disable"

And you can setup a local development environment using

flyte/Makefile

Lines 88 to 89 in 5f801cd

setup_local_dev: ## Sets up k3d cluster with Flyte dependencies for local development
@bash script/setup_local_dev.sh

To modify Admin code and check it locally, I usually add a go replace

flyte/go.mod

Line 221 in 5f801cd

replace github.com/robfig/cron/v3 => github.com/unionai/cron/v3 v3.0.2-0.20210825070134-bfc34418fe84

replace github.com/flyteorg/flyteadmin => ../flyteadmin

@katrogan
Copy link
Contributor

katrogan commented Sep 9, 2022

this is an incredibly stale PR, but this is how far we made it last time trying to get sqlite in admin working: flyteorg/flyteadmin#374

@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service stale
Projects
None yet
Development

No branches or pull requests

4 participants