Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONContent integration incomplete #433

Open
zagy opened this issue Jan 9, 2024 · 2 comments
Open

JSONContent integration incomplete #433

zagy opened this issue Jan 9, 2024 · 2 comments

Comments

@zagy
Copy link
Member

zagy commented Jan 9, 2024

I think it's meant to be used just like this, e.g. self += JSONContent(…) but that's inconsistent with text content where one uses File(…). So my expectation would be either File(content=JSONContent(…)) or File(json=…)
@elikoga
Copy link
Member

elikoga commented Jan 9, 2024

See https://github.com/flyingcircusio/batou/blob/0a3096117f63455bb040825f577a887a928c16ff/src/batou/lib/file.py#L113C17-L124 probably

@zagy
Copy link
Member Author

zagy commented Jan 9, 2024

See https://github.com/flyingcircusio/batou/blob/0a3096117f63455bb040825f577a887a928c16ff/src/batou/lib/file.py#L113C17-L124 probably

Exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zagy @elikoga