Watch ConfigMaps/Secrets referenced in HelmReleases

[jan-kantert]

For performance (less dry-runs) and latency reasons (small queue and faster updates) it would be great if helm-operator would watch its referenced configmaps/secrets and trigger a reconcile on helmreleases. Basically the same as (closed) #143 or the (closed) #42. Any chance to get this eventually?

[stefanprodan]

This is not something that could be done for helm-controller only, if we're adding watchers for Secrets/ConfigMaps they should apply to all Flux controllers with custom resources that have refs, but I'm not considering dynamic watchers. Instead we could add watchers to all Flux controllers based on a predefined label that users should add to the Secrets/ConfigMaps e.g. toolkit.fluxcd.io/watch: enabled. In each controller we would create custom indexes based on the ref type/name/namespace similar to:

helm-controller/internal/controller/helmrelease_controller.go

Lines 116 to 126 in c8ae4b6

	if err := mgr.GetFieldIndexer().IndexField(ctx, &v2.HelmRelease{}, v2.SourceIndexKey,
	func(o client.Object) []string {
	obj := o.(*v2.HelmRelease)
	namespacedName, err := getNamespacedName(obj)
	if err != nil {
	return nil
	}
	return []string{
	namespacedName.String(),
	}
	},