From 82671cfd247567f8e10667f10d9d048662c984fe Mon Sep 17 00:00:00 2001 From: Max Tantow Date: Tue, 3 Sep 2024 17:40:13 +0200 Subject: [PATCH] tests: use tempdir to avoid manual gc Signed-off-by: Max Tantow --- cmd/flux/build_kustomization_test.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/cmd/flux/build_kustomization_test.go b/cmd/flux/build_kustomization_test.go index 383fb1fc07..657171a556 100644 --- a/cmd/flux/build_kustomization_test.go +++ b/cmd/flux/build_kustomization_test.go @@ -22,6 +22,7 @@ package main import ( "bytes" "os" + "path/filepath" "testing" "text/template" ) @@ -118,6 +119,8 @@ spec: cluster_region: "eu-central-1" ` + tmpFile := filepath.Join(t.TempDir(), "podinfo.yaml") + tests := []struct { name string args string @@ -132,25 +135,25 @@ spec: }, { name: "build podinfo", - args: "build kustomization podinfo --kustomization-file ./testdata/build-kustomization/podinfo.yaml --path ./testdata/build-kustomization/podinfo", + args: "build kustomization podinfo --kustomization-file " + tmpFile + " --path ./testdata/build-kustomization/podinfo", resultFile: "./testdata/build-kustomization/podinfo-result.yaml", assertFunc: "assertGoldenTemplateFile", }, { name: "build podinfo without service", - args: "build kustomization podinfo --kustomization-file ./testdata/build-kustomization/podinfo.yaml --path ./testdata/build-kustomization/delete-service", + args: "build kustomization podinfo --kustomization-file " + tmpFile + " --path ./testdata/build-kustomization/delete-service", resultFile: "./testdata/build-kustomization/podinfo-without-service-result.yaml", assertFunc: "assertGoldenTemplateFile", }, { name: "build deployment and configmap with var substitution", - args: "build kustomization podinfo --kustomization-file ./testdata/build-kustomization/podinfo.yaml --path ./testdata/build-kustomization/var-substitution", + args: "build kustomization podinfo --kustomization-file " + tmpFile + " --path ./testdata/build-kustomization/var-substitution", resultFile: "./testdata/build-kustomization/podinfo-with-var-substitution-result.yaml", assertFunc: "assertGoldenTemplateFile", }, { name: "build deployment and configmap with var substitution in dry-run mode", - args: "build kustomization podinfo --kustomization-file ./testdata/build-kustomization/podinfo.yaml --path ./testdata/build-kustomization/var-substitution --dry-run", + args: "build kustomization podinfo --kustomization-file " + tmpFile + " --path ./testdata/build-kustomization/var-substitution --dry-run", resultFile: "./testdata/build-kustomization/podinfo-with-var-substitution-result.yaml", assertFunc: "assertGoldenTemplateFile", }, @@ -161,8 +164,6 @@ spec: } setup(t, tmpl) - testEnv.CreateObjectFile("./testdata/build-kustomization/podinfo-source.yaml", tmpl, t) - temp, err := template.New("podinfo").Parse(podinfo) if err != nil { t.Fatal(err) @@ -174,11 +175,10 @@ spec: t.Fatal(err) } - err = os.WriteFile("./testdata/build-kustomization/podinfo.yaml", b.Bytes(), 0666) + err = os.WriteFile(tmpFile, b.Bytes(), 0666) if err != nil { t.Fatal(err) } - t.Cleanup(func() { _ = os.Remove("./testdata/build-kustomization/podinfo.yaml") }) for _, tt := range tests { t.Run(tt.name, func(t *testing.T) {