Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(development guide): Add information about form fields in dev guide #72

Merged
merged 10 commits into from
Oct 21, 2024

Conversation

fivetran-satvikpatil
Copy link
Contributor

Ticket: T-797928

Changes

Add information about form fields in the development guide, and another few doc changes

@fivetran-satvikpatil
Copy link
Contributor Author

@fivetran-dejantucakov Please review this PR.

@fivetran-dejantucakov
Copy link
Contributor

@5tran-alexil Can you please take this one?
Cc: @fivetran-satvikpatil

development-guide.md Outdated Show resolved Hide resolved
development-guide.md Outdated Show resolved Hide resolved
development-guide.md Outdated Show resolved Hide resolved
development-guide.md Outdated Show resolved Hide resolved
development-guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@5tran-alexil 5tran-alexil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-satvikpatil see my comments inline, looks good.

@fivetran-dejantucakov fivetran-dejantucakov removed their request for review October 15, 2024 18:25
Copy link
Collaborator

@alsnkline alsnkline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. one minor suggestion

development-guide.md Outdated Show resolved Hide resolved
@5tran-alexil
Copy link
Contributor

@fivetran-backend create demo

development-guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@5tran-alexil 5tran-alexil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-satvikpatil fivetran-satvikpatil merged commit f0d8b25 into main Oct 21, 2024
1 check passed
@fivetran-satvikpatil fivetran-satvikpatil deleted the satvik/setup-form-doc branch October 21, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants