Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove converted_at and has_started_with_gift fields from subscription history table #15

Open
1 of 4 tasks
fivetran-joemarkiewicz opened this issue Oct 22, 2024 · 0 comments
Assignees
Labels
type:enhancement New functionality or enhancement

Comments

@fivetran-joemarkiewicz
Copy link
Collaborator

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

We currently include the converted_at and has_started_with_gift fields in the subscription_history staging model. However, we do not use these fields anywhere else downstream. Further, we now know that these fields will be removed from the subscription_history table in the near future and be moved to a separate table that will be created to store these fields and other gift card mapping fields.

As such, we should remove these fields from the subscription_history table to be up to date with the connector. The absence of these fields from the source tables should not result in unexpected failures (due to the presence of the converted_at and started_with_gift fields in the subscription history get columns macro) but will rather generate null records when these fields are not present for new or existing dbt package installations, However, we should address this in an upcoming release to be consistent with the connector.

How would you implement this feature?

See the above notes. We would simply remove the fields and make this a breaking change.

Describe alternatives you've considered

Leave the fields in the staging models. However, this will result in null records and a deviation from the connector which could cause confusion.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance.
  • No.

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants