[Feature] Remove converted_at
and has_started_with_gift
fields from subscription history table
#15
Labels
type:enhancement
New functionality or enhancement
Is there an existing feature request for this?
Describe the Feature
We currently include the
converted_at
andhas_started_with_gift
fields in the subscription_history staging model. However, we do not use these fields anywhere else downstream. Further, we now know that these fields will be removed from the subscription_history table in the near future and be moved to a separate table that will be created to store these fields and other gift card mapping fields.As such, we should remove these fields from the subscription_history table to be up to date with the connector. The absence of these fields from the source tables should not result in unexpected failures (due to the presence of the converted_at and started_with_gift fields in the subscription history get columns macro) but will rather generate
null
records when these fields are not present for new or existing dbt package installations, However, we should address this in an upcoming release to be consistent with the connector.How would you implement this feature?
See the above notes. We would simply remove the fields and make this a breaking change.
Describe alternatives you've considered
Leave the fields in the staging models. However, this will result in
null
records and a deviation from the connector which could cause confusion.Are you interested in contributing this feature?
Anything else?
No response
The text was updated successfully, but these errors were encountered: