Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice tax lines #42

Open
2 of 4 tasks
caffeinebounce opened this issue Mar 19, 2023 · 4 comments
Open
2 of 4 tasks

Invoice tax lines #42

caffeinebounce opened this issue Mar 19, 2023 · 4 comments
Labels
status:scoping Currently being scoped type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Comments

@caffeinebounce
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

I would like this to pull through the tables needed for invoice tax lines. I believe the required tables would be invoice_tax_line, tax_rate, and tax_agency. These are available in the base Fivetran QB connector, but are not pulled through into this flow.

In my QB, these are used to drive a tax payables line on the balance sheet. The addition of these tables is a pre-requisite to additional downstream changes to bring those calculations into the data pipeline. Without these changes the balance sheet and cash flow statement is off.

Describe alternatives you've considered

n.a.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@caffeinebounce caffeinebounce added the enhancement New feature or request label Mar 19, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @caffeinebounce thanks for opening this issue and raising awareness to the need of the tax information associated with your invoices. This seems to be a similar request to Issue #56 on our quickbooks transformation package.

We are currently evaluating and understanding how to include these fields within our package and downstream transformations. I will share more details here once we are able to include this feature in an upcoming sprint and future release. We will also likely share branch details so you may test the working branch prior to release in order to ensure the data is accurate.

Thanks!

@caffeinebounce
Copy link
Author

Yes, that's the same issue.

I have it fixed on my end (with repos I forked), but there seems to be a limitation with Quickbooks Online where there doesn't seem to be an exposed mapping between the TAX_AGENCY and an ACCOUNT in the chart of accounts (at least not one I can find). Not sure if it's a quirk with how my accountants do things. To get around this, I had to manually map the lines in the dbt code, which is not ideal. If helpful, my fix is in the two commits below. I've tested on my data and it works.

0bfe86d
fivetran/dbt_quickbooks@66e2001

@fivetran-joemarkiewicz
Copy link
Contributor

Thanks so much for sharing @caffeinebounce!

I will take a look at your fork and may have some additional follow up questions as we continue to investigate this.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:enhancement New functionality or enhancement status:scoping Currently being scoped update_type:feature Primary focus is to add new functionality and removed enhancement New feature or request labels Apr 7, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

HI @caffeinebounce I am starting to work on integrating these features and scope out how to account for tax lines appropriately. I noticed you have some work on a forked version of the package.

If you wanted to open a PR with your additions I would be happy to collaborate and include your contributions! I may make some modifications to ensure this works for all users, but would be happy to review and leverage your contributions if you were interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:scoping Currently being scoped type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Development

No branches or pull requests

2 participants