Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Reference value of @activity_method(name=name) in Worker.register_activities_implementation() #11

Open
firdaus opened this issue Apr 11, 2021 · 0 comments

Comments

@firdaus
Copy link
Owner

firdaus commented Apr 11, 2021

Hi,

I've found some issues regarding naming of activities (activtyType.name attribute). On the workflow side it is inferred from ActivityInterfaceClassName::method_name or you can give it a custom name by means of the name parameter of the activity_method decorator, thats all fine.

Unfortunately on the activity side (register_activities_implementation) you have very little room for setting the activityType and the two :: are always there. So consider integration with a workflow code written in Java - you have to anticipate this issue and explicitly rename the activity interface so that it fits this convention. Have you considered allowing for passing the activityType.name directly to register_activities_implementation? Or maybe it is possible to somehow make use of the name param passed via the activity_method decorator (one would expect to inherit ActivitiesImplementation from ActivitiesInterface anyway right)?

Originally posted by @Malicious1 in #6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant