Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #8

Open
fhightower opened this issue Feb 27, 2021 · 4 comments
Open

Add type annotations #8

fhightower opened this issue Feb 27, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@fhightower
Copy link
Owner

fhightower commented Feb 27, 2021

We should add type annotations on all public interfaces in this library.

@fhightower fhightower added the enhancement New feature or request label Feb 27, 2021
@fhightower fhightower added the help wanted Extra attention is needed label Nov 15, 2022
@mlliarm
Copy link

mlliarm commented Nov 24, 2022

Hey, @fhightower, I found recently your lib, because I wanted to create a fast script that can convert an XML/HTML response of a curl to a JSON format (curl <endpoint> | ./converter.py | prettyjson). Really useful lib, thanks !

I can help with the type annotations. I've used them in most of my python repos.

@fhightower
Copy link
Owner Author

Thanks for reaching out @mlliarm (and sorry about the slow response). Glad to hear it's useful!

That would be great if you can add type annotations (or even some type annotations would be helpful)! I'll assign this issue to you, but please reach out if you have any questions.

@mlliarm
Copy link

mlliarm commented Feb 1, 2023

Hello,

Apologies for stalling, but there was too much work in my dayjob.

I've already added the annotations in my fork, but correcting the unit test suite took some time, and wanted to have a full green pass from all the tests before sending the PR.

As I'm on holidays for the next 3 weeks and have the required time and energy, I'll try finishing both this issue and #16 within February.

Cheers

@fhightower
Copy link
Owner Author

Totally understand - I've been pretty slammed myself. Any contributions are appreciated and no rush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants