FlowBuilder breaks Navigator 2.0 system level routing (deep links specifically)

[pstromberg98]

Describe the bug
Not sure if this is a "defect" of flow_builder, but it might be worth mentioning in the docs.

Using FlowBuilder alongside AutoRoute (and probably any Navigator 2.0 based solution) will break deep linking. This is because flow_builder sets its own handler for the SystemNavigation.instance method channel thus hijacking all system level routing calls (didPopRoute, didPushRoute, etc).

To Reproduce
Steps to reproduce the behavior:

1. Set up project with AutoRoute
2. Set up deep linking (https://docs.flutter.dev/ui/navigation/deep-linking)
3. Set initial route to contain a FlowBuilder widget
4. Try to deep link to app in foreground (xcrun simctl openurl booted https://{your-domain}/)
5. AutoRoute doesn't receive deep link (deepLinkBuilder callback isn't ran)

Expected behavior
Not sure. If FlowBuilder isn't supposed to be used with Navigator 2.0 routing packages then I think it should be mentioned in the documentation or README. If we want it to be able to coexist with Navigator 2.0 routing packages then I would expect FlowBuilder to not interfere/break them.

Additional context
I have only tested this with AutoRouter and have confirmed the issue (and that removing FlowBuilder fixes it).

[felangel]

Thanks for reporting this! This is definitely a bug imo and FlowBuilder should both support deep linking itself as well as work nicely with existing packages. Are you able to share a minimal reproduction sample? Thanks!

[pstromberg98]

@felangel Sure! I'll throw something together soon.

[vasilich6107]

Hi @felangel here is a repro repop.
Check the uri text at the top of the screen
After opening the flow page - universal links are not woking anymore

https://github.com/artflutter/flow_builder_unilinks_bug

Screen.Recording.2024-03-01.at.9.49.11.AM.mov

[vasilich6107]

Hi
@felangel could you take a look

[vasilich6107]

Good evening @felangel
It would be nice to get a response
Thanks

[felangel]

Good evening @felangel
It would be nice to get a response
Thanks

Hey sorry for the slow response I’ll try to take a look either today or tomorrow 👍

[vasilich6107]

Hi @felangel
Did you have a chance to take a look?

[felangel]

Hi @felangel Did you have a chance to take a look?

Sorry this slipped through the cracks! Will try to find some time in the next few days to look 👍

[vasilich6107]

Hi @felangel just a friendly reminder :-)

[uberchilly]

A sImilar thing happened to me as well on the web: When I navigate to a screen that has FlowBuilder browser back (which should be the same as deep-linking) stops working

[vasilich6107]

Hi @felangel
Any updates?

[vasilich6107]

• knok knok @felangel
• who's there?
• it's me, the bug

[felangel]

• knok knok @felangel
• who's there?
• it's me, the bug

Apologies for the delay! Planning to look at this once I get back from FlutterCon next week, thanks for the bump!

[Peetee06]

hey @felangel, just came across this and thought I'll give it another bump. :)

[felangel]

hey @felangel, just came across this and thought I'll give it another bump. :)

Thanks will try to finally get to this this week 🤞