Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F24/F48 report of independent expenditures report_type, form_type issues #5768

Open
3 tasks
cnlucas opened this issue Mar 20, 2024 · 0 comments · May be fixed by #6061
Open
3 tasks

F24/F48 report of independent expenditures report_type, form_type issues #5768

cnlucas opened this issue Mar 20, 2024 · 0 comments · May be fixed by #6061
Assignees
@hcaofec
Labels
Data Issue Pairing opportunity Work: Back-end Work: Content
Milestone
26.6

Comments

@cnlucas
Copy link
Member

cnlucas commented Mar 20, 2024 •
edited by hcaofec
Loading

What we’re after

We seem to be misidentifying reports vs notices in report and form type. Form 24 was removed from form types back in 2018 This was confusing for our internal users and we should revisit this decision to see if we can make it more clear.

Here's the slack thread with more info:
https://fecgov.slack.com/archives/C61BMLS9X/p1710936877284889?thread_ts=1710516368.390379&cid=C61BMLS9X

From Paul:

v1/candidate/{candidate_id}/filings/, /v1/committee/{committee_id}/filings/ and /v1/filings/
  report_type
    - 48 48 Hour Notification - should be 48 48 hour report of independent expenditures (F5, F24/F3X)
    ADD 24 24 hour report of independent expenditures (F5, F24/F3X)
    - 24 24 Hour Notification (F6, F9)
  form_type
    F24 seems to be missing
  form_category
    NOTICE F5, F24, F6, F9, F10, F11
    F5 and F24 are not notices

/v1/operations-log/
  report_type
    - 48 48 Hour Notification - should be 48 48 hour report of independent expenditures (F5, F24/F3X)
    ADD 24 24 hour report of independent expenditures (F5, F24/F3X)
    - 24 24 Hour Notification (F6, F9)

Action item(s)

  • Refactor filings MV to update form_category
  • Refactor docs.py

Completion criteria

  • form_type, form_category and report_type have list of correct values
@hcaofec hcaofec self-assigned this Sep 30, 2024
@hcaofec hcaofec added this to the 26.3 milestone Sep 30, 2024
@cnlucas cnlucas modified the milestones: 26.3, 26.4 Oct 8, 2024
@cnlucas cnlucas moved this to 📥 Assigned in Website project Oct 8, 2024
@tmpayton tmpayton modified the milestones: 26.4, 26.5 Oct 22, 2024
@hcaofec hcaofec moved this from 📥 Assigned to 🏗 In Progress in Website project Oct 24, 2024
@hcaofec hcaofec modified the milestones: 26.5, 26.6 Nov 5, 2024
@hcaofec hcaofec linked a pull request Nov 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcaofec hcaofec

Labels
Data Issue Pairing opportunity Work: Back-end Work: Content
Projects
Website project
Status: 🏗 In Progress
Milestone
26.6
Development

Successfully merging a pull request may close this issue.

Update report_type, form_type and form_category fecgov/openFEC
3 participants
@hcaofec @cnlucas @tmpayton