Fix is-loading bug on Filings/Reports urls with existing querystring parameters #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6488 +/- ##
========================================
Coverage 79.91% 79.91%
========================================
Files 235 235
Lines 5147 5147
========================================
Hits 4113 4113
Misses 1034 1034 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
Fixes bug on for Filing or Reports datatables where the the loading gif (three dots) keeps animating wen visiting a url with querystring parameters
Required reviewers
one frontend
Impacted areas of the application
Filings and Reports datatables
How to test
npm run build-jsFiling informationsection of the filter panel:is-loadinggif is not persisting