Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humanize selected-stored colours #19

Open
ghost opened this issue Apr 22, 2015 · 1 comment
Open

Humanize selected-stored colours #19

ghost opened this issue Apr 22, 2015 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 22, 2015

It would be a good idea to add a colours database with color_name and color_hex_value columns, to show to user (e.g. with a Toast) a specific color name when the HEX value for selected user color matching with one of records into database.

@ghost ghost added this to the 1.5.0 milestone Apr 22, 2015
@ghost ghost added the enhancement label Apr 22, 2015
@fasteque
Copy link
Owner

For not all the colours makes sense to provide a name (in many places you see things like "grey2", "grey3", "grey4", ...) so we can pick one link (for example: http://www.colorhexa.com/color-names) and provided a pre-loaded sqlite database in the assets folder which will be loaded the first time the application is started (some info here http://fedepaol.github.io/blog/2014/04/08/preloading-localized-data-in-sqllte/ and here http://stackoverflow.com/questions/25518895/using-preloaded-sqlite-database-in-android). But it would be also interesting to give the user the possibility to add their custom names.

Foreseen changes in the application:

  • preloaded db in the assets folder with color names associated to the HEX (or RGB) value;
  • in the launcher activity we check the presence of the db in the private app space: if it's not present we copy it, otherwise nothing will be done;
  • alter the current database to add a column to store the name (remember onUpgrade too!);
  • update the ContentProvider;
  • every time the user add a color pressing the + button, a dialog will appear to insert the name. If that color has a name in our preloaded db, the EditText will be pre-filled, giving anyway the possibility to change the name.
  • update the color panel in home page to also show the name (the add + button is updated if a color is stored or not in the database)

@fasteque fasteque removed this from the 1.5.0 milestone Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant