Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue in patch decorator when worker with abstract classes #536

Open
loayshaqir1 opened this issue Oct 3, 2023 · 0 comments
Open

issue in patch decorator when worker with abstract classes #536

loayshaqir1 opened this issue Oct 3, 2023 · 0 comments

Comments

@loayshaqir1
Copy link

patch decorator is a little bit problematic when working with abstract classes,
consider the following code:

from abc import ABC, abstractmethod
from fastcore.basics import patch


class A(ABC):
    @abstractmethod
    def foo(self):
        pass

class B(A):
    def __init__(self):
        pass

@patch
def foo(self : B):
    print("foo patched to B")

  a = B()
Executing the code yields this error:
TypeError: Can't instantiate abstract class B with abstract methods foo

The reason for that problem is that in Python each class that is inheriting from an abstract class he starts with an attribute called abstractmethods which is a frozenset that contains a set of functions that should be implemented by the child class, this attribute gets updated only in the scope of the class definition and at the end the set should be empty i.e the child class has implemented all the abstractmethods, since we are using patch to separate functions into different cells, Python doesn't see that we actually implemented the required functions.

possible solution, that's the decorator that we used in our code (you can learn from it what you should do to fix on your end):

def patch_method(func : Callable, *args, **kwargs) -> None:
    """
    Applies fastcore's `patch` decorator and removes `func` from `cls.__abstractsmethods__` in case <br>
    `func` is an `abstractmethods`
    """
    cls = next(iter(get_type_hints(func).values()))
    try:
        abstracts_needed = set(cls.__abstractmethods__)
        abstracts_needed.discard(func.__name__)
        cls.__abstractmethods__ = abstracts_needed
    except AttributeError: # If the class does not inherit from an abstract class
        pass
    finally:
        # Apply the original `patch` decorator
        patch(*args, **kwargs)(func)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant