Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http2 transport code not included in cmakelist #464

Open
Revaj opened this issue Sep 14, 2021 · 2 comments
Open

Http2 transport code not included in cmakelist #464

Revaj opened this issue Sep 14, 2021 · 2 comments

Comments

@Revaj
Copy link
Contributor

Revaj commented Sep 14, 2021

Hello, I see fbthritft supports http2 as transport. But in thrift/lib/cpp2/CMakeLists.txt I don't see it's included. Is there a reason of why it's not included?

@Revaj Revaj changed the title Http2 transport code not included in cmakelis Http2 transport code not included in cmakelist Sep 14, 2021
@Revaj
Copy link
Contributor Author

Revaj commented Sep 22, 2021

I mean, I see Header and Rocket code are included in the fbthrift libraries, but not HTTP2, and it will be good to include http2 code as part of the libraries, unless there is a good reason. 😸

@antaljanosbenjamin
Copy link

Actually the examples are depending on HTTP2:

return std::make_unique<HTTP2RoutingHandler>(
std::move(h2_options), server->getThriftProcessor(), *server);

Is there any reason why are they included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants