Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of the DeputyGuardianModule Proxy Change #112

Open
Ethnical opened this issue Oct 4, 2024 · 9 comments
Open

Review of the DeputyGuardianModule Proxy Change #112

Ethnical opened this issue Oct 4, 2024 · 9 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Ethnical
Copy link
Contributor

Ethnical commented Oct 4, 2024

Review of the DeputyGuardianModule Proxy Change

Introduce a proposal that will prevent to regenerate the PSPs and make some unnecessary changes to the guardian contract each time we update the DeputyGuardianModule code.

Date, Time and Duration
Wednesday, 9 October 2024 at 11 EDT, 20-30 minutes.

Design Doc

Additional Context
If the changes are accepted, we should also leverage this opportunity to make some other requested changes for Incident response improvements

Requested Attendees
@maurelian @tynes @ajsutton @smartcontracts

@Ethnical Ethnical added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 4, 2024
@op-aaron
Copy link
Contributor

op-aaron commented Oct 4, 2024

@Ethnical - Just posted on OP Stack calendar. Please confirm that this looks good to you feel free to close the ticket!✨. (note anyone invited can add attendees if they'd like)

@Ethnical
Copy link
Contributor Author

Ethnical commented Oct 7, 2024

Thanks @op-aaron this is good :) We should also add it on Discord Calendar? To make sure contributors can join also wdyt?

@op-aaron
Copy link
Contributor

op-aaron commented Oct 7, 2024

Great! Thanks for the quick check @Ethnical . I need to check in with @tynes and some of the Discord folks to understand the policy around the Discord calendar. Historically we have not put design reviews, stand-ups, or most of the events from the OP Stack calendar on the Discord event calendar. I'm not opposed but I want to understand why before duplicating the event manually as this can introduced "multiple source of truth" issues (i.e. if the time or recipients get changes, meeting link is bad, etc ...).

That said, if you feel it is important then I can request it be added. Just let me know. I believe the thinking is that the OP Stack calendar is a more open resources it is public and doesn't require an invite unlike the Discord server. So this allows you to invite external (not joined to Discord) folks to the event vs. having it live in Discord.

@op-aaron
Copy link
Contributor

op-aaron commented Oct 7, 2024

@Ethnical - The policy is to only use the Discord events for the protocol office hours and direct folks to the public calendar for all other events like design reviews. That said, I've asked the admin to add a link to the public cal in the events section to clarify that is where the majority of events live. So, next time, someone will be able to click through to see the public cal with all events.

I'm going to close this issue for now since the event was posted but - as I said - if you feel it is critical to have this reflected in the Discord Events I can facilitate that for you 🙏

@op-aaron op-aaron closed this as completed Oct 7, 2024
@Ethnical
Copy link
Contributor Author

Ethnical commented Oct 8, 2024

@op-aaron I forgot to answer back..
Yes make completely sense this is not mandatory to make this one for discord it was just a friendly reminder about it.
But that make completely sense to it 🫡

@op-aaron
Copy link
Contributor

op-aaron commented Oct 9, 2024

@bobajeanjacques-op - Can you please upload the recording of this meeting to our youtube channel when you have a chance?

I've re-opened the ticket and assigned to you so please feel free to close once done. Of course, please let me know if you have any questions or need any more info. Thank you!

Meeting link: https://drive.google.com/file/d/1r8jcM19M9LC6KFbkg-P62IG1SytJq8eR/view?usp=drive_web
Title: Design Review of the DeputyGuardianModule Proxy Change
Description:
This design review meeting introduces a proposal to prevent the regeneration of the PSPs and unnecessary changes to the guardian contract each time we update the DeputyGuardianModule code. If the changes are accepted, we should also leverage this opportunity to make some other requested changes for Incident response improvements

Please review the Design Doc for more information.

@bobajeanjacques-op
Copy link

@op-aaron requested access!

@op-aaron
Copy link
Contributor

Doh! Sorry about that, I just shared with you @bobajeanjacques-op and will make sure I do this in advance next time. Please let me know if you have any issues accessing the recording!

@op-aaron
Copy link
Contributor

@amandaoptimist - JJ suggested that you might be able to help us with this request. Can you please post the design meeting to OP youtube channel when you have a chance (not urgent). I've included the info to use to post it above but please let me know if you have any questions. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants