Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable ete4 release #739

Closed
Zethson opened this issue Feb 6, 2024 · 5 comments
Closed

Stable ete4 release #739

Zethson opened this issue Feb 6, 2024 · 5 comments
Assignees

Comments

@Zethson
Copy link

Zethson commented Feb 6, 2024

Hi,

I have a package that is dependent on ete3 and I'm still getting lots of reports from people that have trouble installing my package because they can't install ete3. Be it Macs or even Intel/Amd based clusters.

I am hoping that more installation issues will be resolved with ete4 which, if I read correctly, no longer has pyqt dependencies. I was wondering what the timeline for a stable ete4 release is given that you put out a 4.1.0 pre-release already?

Thank you very much!

@jhcepas
Copy link
Member

jhcepas commented Feb 6, 2024

Hi Lukas,
thanks for contacting.
Yes, all our efforts are currently on ete4. Depending on how you are using ete3, you could consider migrating to ete4 now, as many things are already stable. But, some syntax has changed and a few modules are not fully migrated/tested yet. We could advise on the migration if that helps. May I ask what is your project and what ete3 features does it use?
thanks!

@Zethson
Copy link
Author

Zethson commented Feb 6, 2024

Thanks!

We could advise on the migration if that helps. May I ask what is your project and what ete3 features does it use? thanks!

This is the project: https://github.com/theislab/pertpy and it's only used in here: https://github.com/theislab/pertpy/blob/main/pertpy/tools/_coda/_base_coda.py. It's probably fine if you just CTRL-F ete3 in that file. We're not using a lot of features.

I'd be very happy if you could help us migrate (maybe even with a quick PR?) but to be able to make releases of pertpy, we'd need an ete4 candidate on pypi.

Thanks again!

@dengzq1234 dengzq1234 self-assigned this Mar 28, 2024
@Zethson
Copy link
Author

Zethson commented May 20, 2024

@dengzq1234 I saw that you assigned yourself to this issue and I was wondering whether you'd be up for that? I'm happy to guide a bit on the general code etc if necessary. Thanks!

@dengzq1234
Copy link
Contributor

dengzq1234 commented May 20, 2024 via email

@dengzq1234
Copy link
Contributor

@Zethson PR in regards to this thread has been requested in scverse/pertpy#618, therefore I will close this issue and further discussion will be conduct in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants