Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing error messages & internationalization. #28

Open
tomchristie opened this issue Mar 4, 2019 · 2 comments
Open

Customizing error messages & internationalization. #28

tomchristie opened this issue Mar 4, 2019 · 2 comments

Comments

@tomchristie
Copy link
Member

  • We'll want to mark up our error messages as translatable strings.
  • Support an errors = {} argument for overriding the error strings.
  • Support errors as an attribute adding the the defaults, rather than overriding them.
@smartexpert
Copy link

  • We'll want to mark up our error messages as translatable strings.
  • Support an errors = {} argument for overriding the error strings.
  • Support errors as an attribute adding the the defaults, rather than overriding them.

In my forked version of the repo, I've added the ability to override error messages via passing over additional optional keyword arguments to the Field class. I also needed to pass an optional placeholder message for the input form. It can address some of these issues.

This is sort of my first real attempt at contributing to a project so not sure what protocol I should follow. I read the contribution guidelines about prior discussion.

Are you open to me submitting a PR? @aminalaee

@aminalaee
Copy link
Member

@smartexpert Hey, that looks good.

To be honest I think we won't be adding new features to the project as it's not being maintained actively.

If you want maybe you can do #124 in typesystem but the main focus is on projects pinned in the Encode organisation like HTTPX, Starlette and Uvicorn and any kind of contribution is welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants