Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot be used on angle bracket components below Ember 3.8 #119

Open
amk221 opened this issue Sep 1, 2019 · 4 comments
Open

Cannot be used on angle bracket components below Ember 3.8 #119

amk221 opened this issue Sep 1, 2019 · 4 comments

Comments

@amk221
Copy link

amk221 commented Sep 1, 2019

<MyComponent {{on "click" this.doSomething}} />

Fails with Element modifiers are not allowed in components

Demo repo: amk221/-ember-on-modifier@5d9ae9f

@amk221
Copy link
Author

amk221 commented Sep 1, 2019

I realised this addon doesn’t have -polyfill in the name, is that why it doesn’t work on the lower versions?

@amk221
Copy link
Author

amk221 commented Sep 1, 2019

I see now that this is due to missing behaviour to do with splattributes, not the on modifier.

@amk221 amk221 closed this as completed Sep 1, 2019
@buschtoens buschtoens changed the title Broken in < 3.8 on Angle bracket components Cannot be used on angle bracket components below Ember 3.8 Sep 2, 2019
@buschtoens buschtoens reopened this Sep 2, 2019
@buschtoens
Copy link
Collaborator

Hey @amk221! Thanks for making this explicit.

If you want, you can submit a PR to add this to Compatibility. If you got no time for it, that's also fine. I'll get to it myself then.

@rwjblue
Copy link
Member

rwjblue commented Sep 2, 2019

Yeah, I really wish we could polyfill that behavior but it is quite hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants