Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph::symbol_graph should support arbitrary symbol structures #1

Open
3 tasks
Tracked by #8
elycruz opened this issue Oct 8, 2022 · 0 comments
Open
3 tasks
Tracked by #8

graph::symbol_graph should support arbitrary symbol structures #1

elycruz opened this issue Oct 8, 2022 · 0 comments
Assignees
@elycruz
Labels
enhancement New feature or request in-progress needs-triage

Comments

@elycruz
Copy link
Owner

elycruz commented Oct 8, 2022 •
edited
Loading

Currently this graph struct only supports String values - It should support any arbitrary Send + Sync structs/values.

Other Todos:

  • Symbol trait:
    • id()/get_id() method should return a reference (method currently returns an owned string.
    • id() method should be something less generic; E.g., (get_)symbol_id(), etc.
@elycruz elycruz added the enhancement New feature or request label Oct 8, 2022
@elycruz elycruz self-assigned this Oct 8, 2022
elycruz added a commit that referenced this issue Oct 8, 2022
@elycruz
issue-#1 - Renamed 'symbol_graph' to 'string_graph'.
3cce8e3 
- Renamed 'SymbolGraph' to 'StringGraph'.
elycruz added a commit that referenced this issue Oct 8, 2022
@elycruz
Revert "issue-#1 - Renamed 'symbol_graph' to 'string_graph'."
17fa279 
This reverts commit 3cce8e3.
@elycruz elycruz mentioned this issue Sep 9, 2023
Open
5 tasks
elycruz added a commit that referenced this issue Sep 12, 2023
@elycruz
issue-#1 - [unstable][in-progress] - Progress on symbol_graph convers…
6eb8a53 
…ion.

- Began playing around with returning slices of 'T'  (instead of Vecs, a little more memory efficient), from 'graph::Graph' struct.
- Added placeholder struct for 'GenericSymbol' struct.
- Added prelim. 'Symbol' trait.
elycruz added a commit that referenced this issue Sep 17, 2023
@elycruz
issue-#1 - Updated symbol_graph to allow use of 'GenericSymbol' struct.
a700f58
elycruz added a commit that referenced this issue Sep 17, 2023
@elycruz
issue-#1 - Pulled latest from 'dev'.
0b4da8f
elycruz added a commit that referenced this issue Sep 17, 2023
@elycruz
issue-#1 - Added type generics in tests.
6603bb6
elycruz added a commit that referenced this issue Sep 27, 2023
@elycruz
issue-#1 - Added some optimizations around 'graph::graph', and 'graph…
3dea420 
…::SymbolGraph' APIs to not use 'clone' where no necessary.
elycruz added a commit that referenced this issue Sep 27, 2023
@elycruz
issue-#1 - Updated 'graph::SymbolGraph' tests to use a value with an …
e9e349d 
…'Symbol' trait impl, instead of using 'GenericSymbol' (this struct is still tentative).
elycruz added a commit that referenced this issue Oct 1, 2023
@elycruz
Merge branch 'issue-#1-generic_symbol_graph' of github.com:elycruz/wa…
f3f8fee 
…l-rs into dev
elycruz added a commit that referenced this issue Oct 2, 2023
@elycruz
Merge branch 'issue-#1-generic_symbol_graph' of github.com:elycruz/wa…
2698c71 
…l-rs into dev
elycruz added a commit that referenced this issue Oct 3, 2023
@elycruz
Merge branch 'issue-#1-generic_symbol_graph' of github.com:elycruz/wa…
e448b84 
…l-rs into dev
elycruz added a commit that referenced this issue Oct 14, 2023
@elycruz
Merge branch 'issue-#1-generic_symbol_graph' of github.com:elycruz/wa…
1733318 
…lrs into dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elycruz elycruz

Labels
enhancement New feature or request in-progress needs-triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elycruz