Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elixir.Faker.Pokemon.Ru.location/0 #290

Open
igas opened this issue Oct 4, 2019 · 6 comments
Open

Add Elixir.Faker.Pokemon.Ru.location/0 #290

igas opened this issue Oct 4, 2019 · 6 comments

Comments

@igas
Copy link
Member

igas commented Oct 4, 2019

We want to add Elixir.Faker.Pokemon.Ru.location/0.

If this is the first time you contributing check out this guide.

Comment below if you want to start working on the issue and never be afraid to ask questions.

If you contribute module that does not exist yet here is a good example PR on what you would need to do. If module already exists and you only need to add additional data or new function, check out this PR for the example.

Our changelog can be tricky, when you add yourself, don't forget to add a link to you profile at the bottom of the file (alphabetical order preferred).

Good luck!

@fusillicode
Copy link
Contributor

🙋‍♂️ I would love to work on this!

@fusillicode
Copy link
Contributor

Ok I didn't expect it would have been so difficult to retrieve the Russian translations of Pokemon locations 😆

P.S: I'm trying to look around here and randomly on the Web.

@igas
Copy link
Member Author

igas commented Oct 5, 2019

Haha, this was more like an example issue we plan to add more like this. I'm sure we'll be happy to see Elixir.Faker.Pokemon.It.location/0 :)

@fusillicode
Copy link
Contributor

Oh gosh, thanks a lot 😅
I will surely tackle that Elixir.Faker.Pokemon.It.location/0 as soon as I can!

@fusillicode
Copy link
Contributor

Hi guys 😄

I took the liberty to open 2 separate issues to track both 🇮🇹 Pokemon location & names
Let me know if that's ok 😅

P.S: I've also opened two separate PR 😉

@jake-abed
Copy link

Hi! If there's any interest, could I possibly create an Elixir.Faker.Pokemon.Es module including both Elixir.Faker.Pokemon.Es.name/0 and Elixir.Faker.Pokemon.Es.location/0 functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants