Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate run log schema #35

Open
3 tasks
Tracked by #67
uniqueg opened this issue Jun 20, 2022 · 1 comment
Open
3 tasks
Tracked by #67

fix: validate run log schema #35

uniqueg opened this issue Jun 20, 2022 · 1 comment
Labels
status: blocked Something prevents progress type flag: required by specs Compliance with specs requires this change

Comments

@uniqueg
Copy link
Member

uniqueg commented Jun 20, 2022 •
edited
Loading

cwl-WES currently does not issue spec-compliant run logs (elixir-cloud-aai/cwl-WES/issues/128). Therefore, run log validation has currently been enabled. Once cwl-WES supports spec-compliant run logs, change the following relative to commit f4d7082:

  • pro_wes/client_wes.py:L218-228
  • pro_wes/config.yaml:L65-66
  • pro_wes/tasks/track_run_progress.py:L19&L93-95&L99-101&L141-143&L147-149
@uniqueg
Copy link
Member Author

uniqueg commented Nov 5, 2023 •
edited
Loading

Better to fix this via a cwl-WES compatibility middleware rather than propagating another WES implementations' bad habits.

Depends on #72.

@uniqueg uniqueg added the type flag: required by specs Compliance with specs requires this change label Nov 5, 2023
@uniqueg uniqueg mentioned this issue Nov 5, 2023
Open
5 tasks
@uniqueg uniqueg added the status: blocked Something prevents progress label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: blocked Something prevents progress type flag: required by specs Compliance with specs requires this change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uniqueg