Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM Server 8.16 test plan #14405

Closed
11 tasks done
kruskall opened this issue Oct 21, 2024 · 9 comments
Closed
11 tasks done

APM Server 8.16 test plan #14405

kruskall opened this issue Oct 21, 2024 · 9 comments

Comments

@kruskall
Copy link
Member

kruskall commented Oct 21, 2024

@simitt
Copy link
Contributor

simitt commented Oct 22, 2024

@kruskall IMO we do not need to test the changes in the opentelemetry-lib; confirmed by @lahsivjar

in the test plan, only https://github.com/elastic/opentelemetry-lib/pull/90 is needed to be tested if it hasn't already been tested in the testathon.

@marclop
Copy link
Contributor

marclop commented Oct 24, 2024

Marked elastic/go-docappender#189 as done since it doesn't need to be tested. DynamicTemplates is only exposed in BulkIndexer. APM Server doesn't use this newly added field, nor does the Appender by default.

Marked elastic/apm-data#358 and elastic/apm-data#359 as done since I don't think they need any manual testing.

@endorama
Copy link
Member

I added a unit test for the behavior changes around retry in #13523. PR here: #14433

Does this suffice for considering it done for the test plan?

@1pkg
Copy link
Member

1pkg commented Oct 24, 2024

Similar to above, I had to add an additional concurrent auto test for #14335 in PR here #14443 since it's hard to reproduce manually.

@rubvs
Copy link
Contributor

rubvs commented Oct 29, 2024

Was able to reproduce #14339 via the comments in #14337. However, to see the double in gc ticks, I had to replace time.Sleep(time.Minute) with an uneven count like time.Sleep(5*time.Second)

@lahsivjar
Copy link
Contributor

Successfully tested #14231, details here.

@inge4pres
Copy link
Contributor

@endorama
Copy link
Member

PR #14433 merged, marking 429 changes tested.

@kruskall
Copy link
Member Author

kruskall commented Nov 1, 2024

Tested #14404 thanks to the comment in #14337

Thanks everyone!

@kruskall kruskall closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants