Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Library's setting-aside effect #6

Open
amalloy opened this issue Feb 7, 2014 · 3 comments
Open

Implement Library's setting-aside effect #6

amalloy opened this issue Feb 7, 2014 · 3 comments

Comments

@amalloy
Copy link
Contributor

amalloy commented Feb 7, 2014

I noticed

-- TODO this doesn't set aside any action cards.
- I think you want LibraryEffect to take a function like

libraryChoice :: [Card] -> [Card] -> Card -> Bool
libraryChoice cardsInHand cardsSetAside cardRevealed = -- choose whether to keep it

This isn't quite all the information available (eg, how many cards are left before my shuffle?), so maybe it needs to be lifted into State somehow, but I think it's close enough. If you agree, I think it's within my ability to make that change.

@egonSchiele
Copy link
Owner

Perfect, this is what I was thinking too. If you send over a pull request I'll merge it in.

@amalloy
Copy link
Contributor Author

amalloy commented Feb 8, 2014

I've implemented this in amalloy/dominion@master...library - it's in a separate branch because I don't want to suggest you pull it until it's possible to test it.

@egonSchiele
Copy link
Owner

You should be able to test this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants