-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create equinox repo to merge equinox.bundles and equinox.framework into it #18
Comments
We are doing the same for PDE eclipse-pde/eclipse.pde#35 |
@tjwatson please approved. Worked well for pde.ui to pde |
That's the plan as far as I know. |
Why is any of those required to merge git repositories? |
It is not required. @vogella probably just wanted to be so kind to avoid the extra work to re-create PRs. |
It should be possible to simply push the PR to the new remote? But anyways we can wait if there is a ETA and we do not delay it one more release I think. |
@tjwatson you stay very quit here :-) Can you share you go or no-go for the rename of the repo. We did it in PDE (pde.ui to pde) and IIRC we had no (or at least only little so I forgot them) issues with it. |
Last discussion we had I thought we were leaving both repos as is and creating a new one called |
Sounds good. Shall I open a help desk request to create a new repo or do you want to do this? |
@vogella Please do so. We have to act as we are just spinning here while actual problems are pending and depend (in a way ) on that - #54 (comment) |
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1416 |
@akurtakov done, and I pushed content of equinox.bundles to the new equinox repo. https://github.com/eclipse-equinox/equinox Can someone update the aggegator build and close all pending PR of equinox-bundles? This process would be less disruptive if we renamed the old repo. |
@vogella what about the framework repo? Just in case we adjust the aggregator so no need for double work? |
Yes, I've been following this thread and as soon as the framework repo is merged in I can merge the two setups. |
From releng POV I would like to do the aggregator build changes once as we all have an agreement let's just act on it. |
Master build is running fine now: https://ci.eclipse.org/equinox/job/equinox/job/master/ so I would assume my part is done here :-) |
@laeubi So I should look to make the setup work now? |
At least everything from both repos is in, so from eclipse ide side we should be fine 👍 |
Switches aggregator build to use the new merged equinox repository instead of the old split ones. See eclipse-equinox/equinox.bundles#18
Switches aggregator build to use the new merged equinox repository instead of the old split ones. See eclipse-equinox/equinox.bundles#18
Switches aggregator build to use the new merged equinox repository instead of the old split ones. See eclipse-equinox/equinox.bundles#18
Switches aggregator build to use the new merged equinox repository instead of the old split ones. See eclipse-equinox/equinox.bundles#18
Just some usual statistic: Previous build times where around 35 minutes we are now at around 30 minutes, so not that bad, but on a 16 CPU machine with parallel builds I could get a buildtime of the whole equinox of Total time: 09:33 min (Wall Clock) without any special optimization! So if we are really concerned about build times we:
|
Create new equinox submodule and remove older split bundles See eclipse-equinox/equinox.bundles#18
Create new equinox submodule and remove older split bundles See eclipse-equinox/equinox.bundles#18
PMC decided that we will merge equinox.framework into the equinox.bundles repo. Thomas indicated that a better name would be equinox.
If @tjwatson give his +1 I can open a help ticket to rename the equinox.bundles
Public repo to equinox.
I did this with GEF Legacy. See eclipse-gef/gef-classic#5
The text was updated successfully, but these errors were encountered: