You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried --review-pr on a PR that introduced a binutils-2.42-GCCcore-13.2.0.eb.
That finds binutils-2.42 in other toolchains but not binutils-2.40-GCCcore-13.2.0.eb in the same toolchain.
I suggest to enhance that to also compare against ECs in the same toolchain generation.
This might be useful in general and to catch mistakes like accidentally adding an EC next to an existing one instead of using that.
From the documentation of find_related_easyconfigs:
The following criteria are considered (in this order) next to common software version criterion, i.e.
exact version match, a major/minor version match, a major version match, or no version match (in that order).
(i) matching versionsuffix and toolchain name/version
(ii) matching versionsuffix and toolchain name (any toolchain version)
(iii) matching versionsuffix (any toolchain name/version)
(iv) matching toolchain name/version (any versionsuffix)
(v) matching toolchain name (any versionsuffix, toolchain version)
(vi) no extra requirements (any versionsuffix, toolchain name/version)
That doesn't exactly describe the "next to common software version criterion", i.e. how that relates to the toolchain list.
What I expected:
# 1. Same toolchain & version
# 2. Same toolchain, different version
# 3. Any toolchain
# For each:
# exact version, major/minor version, major version, any version
But that doesn't seem to be the case.
I suggest to
Clarify in the description how the software version matching is related to toolchain matching.
Additionally always include for the same toolchain name/version the first non-empty list that matches one of these 8 possibilities: versionsuffix + exact/majmin/maj/any version, any versionsuffix + exact/majmin/maj/anyversion
The text was updated successfully, but these errors were encountered:
I tried
--review-pr
on a PR that introduced abinutils-2.42-GCCcore-13.2.0.eb
.That finds
binutils-2.42
in other toolchains but notbinutils-2.40-GCCcore-13.2.0.eb
in the same toolchain.I suggest to enhance that to also compare against ECs in the same toolchain generation.
This might be useful in general and to catch mistakes like accidentally adding an EC next to an existing one instead of using that.
From the documentation of
find_related_easyconfigs
:That doesn't exactly describe the "next to common software version criterion", i.e. how that relates to the toolchain list.
What I expected:
But that doesn't seem to be the case.
I suggest to
The text was updated successfully, but these errors were encountered: