Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firedrake_adjoint no longer supported #103

Open
SamAhnert opened this issue Oct 24, 2023 · 3 comments
Open

firedrake_adjoint no longer supported #103

SamAhnert opened this issue Oct 24, 2023 · 3 comments
Assignees
@ludgerpaehler
Labels
bug Something isn't working priority High-priority core feature
Milestone
v1.0 Paper Release

Comments

@SamAhnert
Copy link
Collaborator

The use of the "firedrake_adjoint" module is deprecated in favor of firedrake.adjoint causing breaking changes for our environments ala:

firedrakeproject/firedrake@ddc60a1

Will be fixed in sa/bug-fix-Oct23 branch.
@SamAhnert SamAhnert added the bug Something isn't working label Oct 24, 2023
@SamAhnert SamAhnert self-assigned this Oct 24, 2023
@SamAhnert
Copy link
Collaborator Author

This seems to be a greater problem to do with the differentiability of the environment. Will not prioritize this at the moment, but it seems like the with this new change, differentiability is not supported

@SamAhnert SamAhnert removed their assignment Oct 24, 2023
@ludgerpaehler
Copy link
Collaborator

I am talking with Nacime Bouziani at the moment, so we should hopefully get that fixed soon :)

@ludgerpaehler
Copy link
Collaborator

(One of the Firedrake people who wrote the PyTorch integration)

@ludgerpaehler ludgerpaehler added the priority High-priority core feature label Nov 30, 2023
@ludgerpaehler ludgerpaehler self-assigned this Nov 30, 2023
@ludgerpaehler ludgerpaehler added this to the v1.0 Paper Release milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludgerpaehler ludgerpaehler

Labels
bug Something isn't working priority High-priority core feature
Projects
None yet
Milestone
v1.0 Paper Release
Development

No branches or pull requests
2 participants
@ludgerpaehler @SamAhnert