Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better error message for conflicting dependencies #31

Open
cgay opened this issue Jun 24, 2024 · 1 comment
Open

Need better error message for conflicting dependencies #31

cgay opened this issue Jun 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@cgay
Copy link
Member

cgay commented Jun 24, 2024

This is a terrible error message:

19:51:50 ~/dylan/workspaces/dylox (main*) 
$ deft-app --verbose update
Loading /Users/cgay/dylan/_packages/pacman-catalog/master/src/v1/st/ri/strings
Loading /Users/cgay/dylan/_packages/pacman-catalog/master/src/v1/un/co/uncommon-dylan
Loading /Users/cgay/dylan/_packages/pacman-catalog/master/src/v1/te/st/testworks
Loading /Users/cgay/dylan/_packages/pacman-catalog/master/src/v1/co/mm/command-line-parser
Loading /Users/cgay/dylan/_packages/pacman-catalog/master/src/v1/js/on/json
dependencies on conflicting major versions of the same package: "[email protected]" and "[email protected]" (path: strings)

It needs to say what packages are requiring different major versions of the strings package.

These are the current "dylox" dependencies:

    "dependencies": [
        "strings",
        "uncommon-dylan"
    ],
    "dev-dependencies": [
        "testworks"
    ],

dylox requires "strings" (i.e., strings@latest, i.e., [email protected]) and testworks requires [email protected], so a better message would be:

dependencies on conflicting major versions of the same package: "[email protected]" (via dylox) and "[email protected]" (via testworks).

Not sure what "(path: strings)" is about.

@cgay cgay added the bug Something isn't working label Jun 24, 2024
@cgay
Copy link
Member Author

cgay commented Jul 1, 2024

I can imagine solving this by simply (!) taking the non-dev dependency ([email protected]) and continuing without a fatal error, because dev deps should never change how the main code is built, but I don't like that solution because it just defers the problem. Better to die horribly and force the programmer to update dev deps to something compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant