Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install local assertions into the blossom algorithm #20

Open
ecpeterson opened this issue May 6, 2020 · 1 comment
Open

Install local assertions into the blossom algorithm #20

ecpeterson opened this issue May 6, 2020 · 1 comment

Comments

@ecpeterson
Copy link
Contributor

ecpeterson commented May 6, 2020

In tracing through the algorithm as part of an earlier internal PR, @karalekas suggested a couple of assertions that could be made while respecting memory locality:

  • When installing a master edge, check that the source node of the proposed edge matches your address.
  • When substituting one address for another over a collection of slave targets, check that exactly one such substitution occurs.

There are probably many more assertions that could be introduced which would not violate locality or consume too much runtime—but, in my experience, they are hard to list off without reading through the code line-by-line. This issue is an instruction to take the time to do exactly that.

@ecpeterson ecpeterson transferred this issue from another repository Oct 5, 2022
@ecpeterson
Copy link
Contributor Author

See also #17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant