Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestUser vs. TestClient options attribute #24

Open
mostlyobvious opened this issue Feb 6, 2012 · 0 comments
Open

TestUser vs. TestClient options attribute #24

mostlyobvious opened this issue Feb 6, 2012 · 0 comments

Comments

@mostlyobvious
Copy link
Member

Currently TestUser exposes options attribute publicly. There are no clear use cases for me to have this method public. In fact this causes method conflict in TestClient where options is one of http methods actions.

In order to maintain consistency, TestUser can use @options ivar internally instead of accessor or we can rename and protect accessor. This also means deprecating old options accessor.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant