Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokyo-night storm and moon #827

Open
drishal opened this issue May 5, 2024 · 10 comments · May be fixed by #835
Open

Add tokyo-night storm and moon #827

drishal opened this issue May 5, 2024 · 10 comments · May be fixed by #835
Labels
is:theme Requests that a theme be added or removed needs-triage Issue hasn't been assessed yet

Comments

@drishal
Copy link

drishal commented May 5, 2024

Describe your request

as the title says, if possible please add tokyo night storm and moon variants as well

Resources

https://github.com/folke/tokyonight.nvim

@drishal drishal added is:theme Requests that a theme be added or removed needs-triage Issue hasn't been assessed yet labels May 5, 2024
@Luxvao
Copy link

Luxvao commented Aug 9, 2024

+1

@i-am-linja
Copy link

Can we please also add Day? (Or Light as it's known in VSCode.) Light mode users do exist.

@foster-hangdaan
Copy link

foster-hangdaan commented Aug 17, 2024

I can work on this if possible. I can add the Storm and Light variants. However, I probably won't do the Moon variant as it doesn't seem to be a variant that is listed on the official repo.

@foster-hangdaan foster-hangdaan linked a pull request Aug 17, 2024 that will close this issue
7 tasks
@azzamsa
Copy link

azzamsa commented Aug 19, 2024

@foster-hangdaan The moon variant is the most popular, as it is used by the author of folke/tokyonight.nvim himself.

While https://github.com/tokyo-night/tokyo-night-vscode-theme (enkia) was the original, you'll notice that https://github.com/folke/tokyonight.nvim is more widely adopted, and often serves as a reference for other implementations.

  • https://github.com/folke/tokyonight.nvim: 6.1k stars
  • https://github.com/tokyo-night/tokyo-night-vscode-theme: 1.7k stars

@azzamsa
Copy link

azzamsa commented Aug 19, 2024

For any folke/tokyonight moon variant users, before it gets ported to Doom, you can use doom-moonlight, which is similar.

@foster-hangdaan
Copy link

@foster-hangdaan The moon variant is the most popular, as it is used by the author of folke/tokyonight.nvim himself.

While https://github.com/tokyo-night/tokyo-night-vscode-theme (enkia) was the original, you'll notice that https://github.com/folke/tokyonight.nvim is more widely adopted, and often serves as a reference for other implementations.

* `https://github.com/folke/tokyonight.nvim`: 6.1k stars

* `https://github.com/tokyo-night/tokyo-night-vscode-theme`: 1.7k stars

I'll add the Moon variant to #835 when time permits in order to close this issue in one shot.

@drishal
Copy link
Author

drishal commented Aug 19, 2024

@foster-hangdaan The moon variant is the most popular, as it is used by the author of folke/tokyonight.nvim himself.
While https://github.com/tokyo-night/tokyo-night-vscode-theme (enkia) was the original, you'll notice that https://github.com/folke/tokyonight.nvim is more widely adopted, and often serves as a reference for other implementations.

* `https://github.com/folke/tokyonight.nvim`: 6.1k stars

* `https://github.com/tokyo-night/tokyo-night-vscode-theme`: 1.7k stars

I'll add the Moon variant to #835 when time permits in order to close this issue in one shot.

if possible, an even better option would be to probably tweak all themes according to the neovim theme since ngl those themes look really beautiful

@azzamsa
Copy link

azzamsa commented Aug 19, 2024

if possible, an even better option would be to probably tweak all themes according to the neovim theme since ngl those themes look really beautiful

Yeah, this what I also had in mind.

@i-am-linja
Copy link

The real solution is to divide the themes into tokyonight-* for the VSCode originals and tokyoneo-* for the NVim adaptations.

Shirtposting aside, if we're adopting NVim's tweaks can we please also have italic comments and keywords? Italics are criminally underrepresented in DOOM, and they fit TokyoNight so well.

@foster-hangdaan
Copy link

foster-hangdaan commented Aug 19, 2024

The Moon variant has been added to #835. Unless there are any issues, I think the PR is good to go as-is. I will take the opportunity to add minor tweaks here and there while the PR is still open.


@foster-hangdaan The moon variant is the most popular, as it is used by the author of folke/tokyonight.nvim himself.
While https://github.com/tokyo-night/tokyo-night-vscode-theme (enkia) was the original, you'll notice that https://github.com/folke/tokyonight.nvim is more widely adopted, and often serves as a reference for other implementations.

* `https://github.com/folke/tokyonight.nvim`: 6.1k stars

* `https://github.com/tokyo-night/tokyo-night-vscode-theme`: 1.7k stars

I'll add the Moon variant to #835 when time permits in order to close this issue in one shot.

if possible, an even better option would be to probably tweak all themes according to the neovim theme since ngl those themes look really beautiful

I'm not sure how to go about this while keeping everyone happy. Maybe we need variants of the variants? 🤷 I myself prefer the syntax highlighting and colors of the VSCode version.


The real solution is to divide the themes into tokyonight-* for the VSCode originals and tokyoneo-* for the NVim adaptations.

Shirtposting aside, if we're adopting NVim's tweaks can we please also have italic comments and keywords? Italics are criminally underrepresented in DOOM, and they fit TokyoNight so well.

This can certainly be added but at the price of making the theme more opinionated. Both the original and the Nvim port have italicized comments.

In any case, you can always customize individual font faces by editing ~/.config/doom/custom.el. Here is an example of changing the font family for comments and docstrings:

(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(font-lock-comment-face ((t (:family "MonaspiceRn NFM"))))
 '(font-lock-doc-face ((t (:inherit font-lock-comment-face :family "MonaspiceXe NFM"))))
 '(which-key-docstring-face ((t (:inherit which-key-note-face :family "MonaspiceXe NFM")))))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:theme Requests that a theme be added or removed needs-triage Issue hasn't been assessed yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants