Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support treemacs-ext with nerd-icons instead of all-the-icons #823

Open
tam5 opened this issue Feb 25, 2024 · 3 comments
Open

Support treemacs-ext with nerd-icons instead of all-the-icons #823

tam5 opened this issue Feb 25, 2024 · 3 comments
Labels
is:feature Adds or requests new features, or extends existing ones re:treemacs
Milestone

Comments

@tam5
Copy link
Contributor

tam5 commented Feb 25, 2024

Describe your request

Somewhat recently doom dropped all-the-icons in favor of nerd-icons.

As part of that some of the extra visual tweaks present in doom-themes-ext-treemacs.el, like hiding the modeline for example, seem to have been lost.

What do ya'all think would be a recommended fix? Add a new extension for treemacs-with-nerd, split out treemacs-ext to separate icon handling from the rest, add additional conditional logic to existing treemacs-ext to just skip the all-the-icons stuff?

Briefly explain its use-case

Using doom with treemacs.

@tam5 tam5 added is:feature Adds or requests new features, or extends existing ones needs-triage Issue hasn't been assessed yet labels Feb 25, 2024
@sebastiaanspeck
Copy link

sebastiaanspeck commented Mar 10, 2024

I do not know what the fix would be, but I have at least opened a PR to show the modeline again #824 since Alexander-Miller/treemacs#1049 made the modeline useful again

@Velnbur
Copy link

Velnbur commented Mar 17, 2024

It's actually already done using treemacs-nerd-icons package by updating treemacs-load-theme to nerd-icons (see)

@hlissner hlissner added this to Triage Mar 17, 2024
@hlissner hlissner moved this from Unreviewed to Ready in Triage Mar 17, 2024
@github-project-automation github-project-automation bot moved this to Unreviewed in Triage Mar 17, 2024
@hlissner hlissner added re:treemacs and removed needs-triage Issue hasn't been assessed yet labels Mar 17, 2024
@hlissner hlissner added this to the Backlog milestone Mar 17, 2024
@hlissner hlissner removed this from Triage Mar 21, 2024
@forty
Copy link

forty commented Aug 21, 2024

FYI that's what I did for the neotree extension #816

Sadly it's not as simple as s/all-the/nerd/g, but it's not very complicated either. I don't know if it's the good solution for long term (all the icons is used a bit all over the place in this repo, and I'm not confident enough to do the change everywhere), but it works here for neotree :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature Adds or requests new features, or extends existing ones re:treemacs
Projects
None yet
Development

No branches or pull requests

5 participants