Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slant inconsistent in solarized-light vs solarized-dark #814

Open
real-or-random opened this issue Dec 13, 2023 · 1 comment
Open

Slant inconsistent in solarized-light vs solarized-dark #814

real-or-random opened this issue Dec 13, 2023 · 1 comment
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet

Comments

@real-or-random
Copy link

Theme(s)

doom-solarized-dark, doom-solarized-light

What were you expecting?

Comment slant should be the same in solarized-light vs solarized-dark.

What actually happened?

Slant is italics in the light variant since 3abb53e, but it's upright in the dark variant.

Steps to reproduce

  1. Open a source file with comments
  2. Toggle between solarized-light and solarized-dark.

Operating system

Arch Linux

Emacs version

29.1

Installed commit of doom-themes

abd29569a6b78515599c2133fcb06da3e06bee14

@real-or-random real-or-random added is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Dec 13, 2023
@real-or-random
Copy link
Author

It depends a bit if you consider this a bug. But it's rather annoying when you switch between the dark and the light variant often, e.g., with auto-dark-mode.

I'm happy to submit a PR, but then I need to know whether we want italics or not. I don't really have a preference. I thought @hlissner may have an opinion because he worked on 3abb53e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet
Projects
None yet
Development

No branches or pull requests

1 participant