Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Org fontification extension assumes org-indent is loaded #807

Open
hpfr opened this issue Oct 13, 2023 · 0 comments
Open

Org fontification extension assumes org-indent is loaded #807

hpfr opened this issue Oct 13, 2023 · 0 comments
Labels
is:bug Something isn't working as intended re:org Relates to our org extension
Milestone
Backlog

Comments

@hpfr
Copy link

hpfr commented Oct 13, 2023 •
edited
Loading

What were you expecting?

No Invalid face reference: org-indent [160 times] in the echo area

What actually happened?

doom-themes-enable-org-fontification relies on the org-indent face:

themes/extensions/doom-themes-ext-org.el

Lines 121 to 123 in 4aee1f5

(1 'org-indent append)
(2 'org-list-dt append)
(3 'org-indent append))

This face is defined in the org-indent library. Org does not depend on org-indent; it’s only required by org-mode if org-startup-indented is set.

I’m not sure about the best approach to fix this. Vendoring the defface seems reasonable, since it’s simply ((t (:inherit org-hide))).

Steps to reproduce

Disable org-startup-indented, restart Emacs, and open an Org file

Installed commit of doom-themes

4aee1f5
@hpfr hpfr added is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Oct 13, 2023
@hlissner hlissner added re:org Relates to our org extension and removed needs-triage Issue hasn't been assessed yet labels Dec 2, 2023
@hlissner hlissner added this to the Backlog milestone Dec 2, 2023
@hlissner hlissner added this to Triage Dec 2, 2023
@hlissner hlissner moved this to Confirmed in Triage Dec 2, 2023
@hlissner hlissner removed this from Triage Mar 21, 2024
alexmurray added a commit to alexmurray/dot_emacs.d that referenced this issue Oct 23, 2024
@alexmurray
Workaround doom-themes issue
3940dfa 
"Invalid face reference: org-indent" appearing lots in *Messages* -
doomemacs/themes#807

Signed-off-by: Alex Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:bug Something isn't working as intended re:org Relates to our org extension
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@hlissner @hpfr