Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low contrast with doom-nord-light and marginalia/selectrum #573

Closed
ig-perez opened this issue Feb 22, 2021 · 4 comments · Fixed by #574
Closed

Low contrast with doom-nord-light and marginalia/selectrum #573

ig-perez opened this issue Feb 22, 2021 · 4 comments · Fixed by #574

Comments

@ig-perez
Copy link

Thanks for maintaining this package!

What happened?

After latest update it is hard to read the candidates provided by Marginalia, for example:
image

What did you expect to happen?

Better contrast with the provided text in the candidates list.

Steps to reproduce

  1. Install Marginalia and Selectrum
  2. M-x and write pack
  3. See candidates list, the word pack has almost vanished.

System Information

  • Emacs version: 27.1
  • Emacs Distro: None
  • Operating System: Fedora 33 (Wayland)
  • Installed commit of doom-themes: 3fb14b4
@edmundmiller
Copy link
Member

For me locally:
image

Can you double-check that you're on 3fb14b4? I'm using this branch on my fork doomemacs/doomemacs#4664 if you could try it with that also.

@edmundmiller
Copy link
Member

edmundmiller commented Feb 24, 2021 •
edited
Loading

Okay, I rebased the branch onto dev, and now I've got the same thing. @jmorag any ideas?

jmorag added a commit to jmorag/emacs-doom-themes that referenced this issue Feb 24, 2021
@jmorag
Remove theming for selectrum-*-highlight
39f1e9d 
Fixes doomemacs#573 and
will be forwards-compatible once
radian-software/selectrum#364 is resolved.
@jmorag jmorag mentioned this issue Feb 24, 2021
Merged
@jmorag
Copy link
Contributor

jmorag commented Feb 24, 2021

I've opened a PR with the fix. Apologies for not testing more with light themes @ig-perez!

@ig-perez
Copy link
Author

ig-perez commented Feb 24, 2021 •
edited
Loading

I've opened a PR with the fix. Apologies for not testing more with light themes @ig-perez!

No need to apologize @jmorag Thanks a lot for your time guys.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove theming for selectrum-*-highlight jmorag/emacs-doom-themes
3 participants
@edmundmiller @jmorag @ig-perez