Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Compatibility with djade #1021

Open
2 tasks done
rphlo opened this issue Nov 12, 2024 · 5 comments
Open
2 tasks done

[FEATURE] Compatibility with djade #1021

rphlo opened this issue Nov 12, 2024 · 5 comments

Comments

@rphlo
Copy link

rphlo commented Nov 12, 2024

Feature Request

Hi, First thanks for this project,
Here is my request.

Recently a new project was released https://github.com/adamchainz/djade and it has conflicting formatting rules regarding django jinja templates.
Biggest conflict is regarding white lines around {% block %}, smaller conflict is about naming inlines {% endblock %}

Would be nice to see a common approach regarding those.

I posted a feature request as well in djade repo.
adamchainz/djade#101

@monosans
Copy link
Member

What is the point of this? What will it give to djLint and djade users?

@rphlo
Copy link
Author

rphlo commented Nov 12, 2024

For users that uses both projects (both projects checks are not overlapping completely), it will allow to get a passing tests when committing their code, otherwise there will be always one linter complaining of the output of the other.

@monosans
Copy link
Member

Why would anyone use 2 formatters for the same file type

@rphlo
Copy link
Author

rphlo commented Nov 12, 2024

Djade formats only jinja specific blocks, while djLint formats the html.

@oliverhaas
Copy link
Contributor

oliverhaas commented Nov 15, 2024

Why not use djlint for everything? If you want "compatibility", you actually would need to implement the same formatting in djlint, basically making using djade superfluous.

I don't know what formatting djlint is currently missing, or if there are just minor differences. Can you give an actual example for formatting conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants