Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test fails on python3.5 with error ImportError: No module named 'urlparse' #651

Open
snehlatamohite opened this issue Jun 14, 2017 · 1 comment

Comments

@snehlatamohite
Copy link

Hi All,

make test fails on python3.5 on ubuntu 16.04 with error ImportError: No module named 'urlparse'

I could able to fix the issue by changing import statement inside disco/util.py file from from urlparse import urlparse to from urllib.parse import urlparse.
It looks that in python3.5 from urlparse name has been changed to urllib.parse .

Please let me know if fix is already available.

Thanks,
Snehlata Mohite.

@ghost
Copy link

ghost commented Jun 14, 2017

There are some related tickets as well:

But there is also this:

It might be possible to modify compat.py to add the new syntax for urlparse?

Thanks for looking at using disco with python3.5 on 16.04

Please feel free to make a pull request, and/or ask any questions along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant