Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments from walkthrough with Getty #156

Open
18 of 21 tasks
tomcrane opened this issue Mar 22, 2022 · 0 comments
Open
18 of 21 tasks

Comments from walkthrough with Getty #156

tomcrane opened this issue Mar 22, 2022 · 0 comments
Labels

Comments

@tomcrane
Copy link
Contributor

tomcrane commented Mar 22, 2022

For discussion only (at this stage)

  • Consider changing the default mode to responsive? Sensible default for initial viewer - aspect ratio matching image
  • Improve naming of atlas-viewer component, unclear to it's meaning

Editorial fixes

  • CP without the viewport, example needs to be earlier!
  • relationship between image service, cp tag and atlas viewer: atlas is about layout
  • Link to IIIF cookbook book for chateauroux example - https://preview.iiif.io/cookbook/3333-choice/recipe/0036-composition-from-multiple-images/
  • Responsive images - mention the cache use case, why virtual-sizes help your cache (if used carefully)
  • When describing presets, demonstrate how you can mix attributes on the element and attributes in the JSON (typically canvas-id, manifest-id as attrs, responsive image settings as JSON).
  • Lazy loading: Add note about cp loading smallest image first then following with full display
  • explain how exact-initial-image + change preset gives you viewer that loads static and then becomes zoom
  • region and target attributes: check consistency across image-service and canvas-panel
  • Add demo of linking annotation by adding .href to the annotationDisplay object.
  • Content state encoding and decoding in docs - more on this

Still to do

Won't do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant