Switch to new Bookkeeper Client API #163 #167
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Apr 16, 2020
| LOGGER.log(Level.SEVERE, "error while writing to ledger " + out, err); | ||
| throw err; | ||
| switch (err.getCode()) { | ||
| case BKException.Code.LedgerClosedException: |
There was a problem hiding this comment.
I feel you can leave the original catch clause.
as you are still referencing old BKException.
| exception.set(error); | ||
| res.set(index, null); | ||
| for (int j = 0; j < edits.size(); j++) { | ||
| for (StatusEdit edit1 : edits) { |
There was a problem hiding this comment.
it is better to leave the counted loop
with this change you are using the Iterator ! this is more expensive
| LOGGER.log(Level.SEVERE, "error while writing to ledger " + out, err); | ||
| throw err; | ||
| } catch (Exception err) { | ||
| switch (err.getCode()) { |
| config.setEnableParallelRecoveryRead(true); | ||
| config.setThrottleValue(0); | ||
| config.setEnableDigestTypeAutodetection(true); | ||
| String zkConnString = "zk+null://" + zkAddress + zkPath; |
There was a problem hiding this comment.
what is zkAddress ? is it a list of server addresses ?
server1:port1,server2:port2,server3:port3 ?
| while (seq.hasMoreElements()) { | ||
| LedgerEntry entry = seq.nextElement(); | ||
|
|
||
| Iterator<LedgerEntry> entries = handle.read(start, end).iterator(); |
There was a problem hiding this comment.
try (LedgerEntries entries = handle.read(start, end)) {
for (LedgerEntry entry : entries) {
..........
}
}
| nextEntry = 0; | ||
| continue; | ||
| } | ||
| try (LedgerEntries entries = handler.read(nextEntry, lastAddConfirmed)) { |
| @@ -1042,12 +1074,24 @@ public void followTheLeader(LogSequenceNumber skipPast, BiConsumer<LogSequenceNu | |||
| lastSequenceNumber = number.sequenceNumber; | |||
| currentLedgerId = number.ledgerId; | |||
| } | |||
| } catch (BKException err) { | |||
There was a problem hiding this comment.
it is better to leave off all of these refactor of exception handling
it is very dangerous and it makes the review more difficult
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #163
Formalities
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.