Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main pdfkit repo #2613

Open
16 tasks
diegomura opened this issue Feb 6, 2024 · 3 comments
Open
16 tasks

Use main pdfkit repo #2613

diegomura opened this issue Feb 6, 2024 · 3 comments

Comments

@diegomura
Copy link
Owner

diegomura commented Feb 6, 2024

I'd like to remove pdfkit fork and start using https://github.com/foliojs/pdfkit again. I branched from this a long time ago for multiple reasons, so I'm not sure the lift here. It will mean for sure to add several changes in that repo, which I think it could benefit the entire community, but not sure yet what those are.

I'll keep this issue as a sort of umbrella issue where I'll capture all the differences and report progress as I tackle them. It will be a slow path.

@diegomura diegomura pinned this issue Feb 6, 2024
@wojtekmaj
Copy link
Contributor

Hey, regarding png-js bit - consider pngjs too! See my comment: #676 (comment)

@diegomura
Copy link
Owner Author

Thanks! Just took a quick look, and pngjs has node deps too, meaning I'll need to fork it as for now, or have them onboard on shipping a browser build. And also convince pdfkit to adopt this. Because pdfkit already uses png-js the path towards unifying this is shorter, but I'll check what would be more convenient

@kishaningithub
Copy link

@foliojs Can you kindly pitch in and add your thoughts here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants