From 1daab4201631afb2570ed73a587ae0b27bb9d994 Mon Sep 17 00:00:00 2001 From: eirikhaugstulen Date: Mon, 14 Oct 2024 16:53:32 +0200 Subject: [PATCH 1/2] fix: use title instead of alt on missing icons --- i18n/en.pot | 7 ++----- .../capture-ui/NonBundledIcon/NonBundledIcon.component.js | 4 +++- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/i18n/en.pot b/i18n/en.pot index 9b56b6db68..b1a2483c15 100644 --- a/i18n/en.pot +++ b/i18n/en.pot @@ -5,8 +5,8 @@ msgstr "" "Content-Type: text/plain; charset=utf-8\n" "Content-Transfer-Encoding: 8bit\n" "Plural-Forms: nplurals=2; plural=(n != 1)\n" -"POT-Creation-Date: 2024-10-10T14:29:59.249Z\n" -"PO-Revision-Date: 2024-10-10T14:29:59.249Z\n" +"POT-Creation-Date: 2024-10-14T14:53:34.553Z\n" +"PO-Revision-Date: 2024-10-14T14:53:34.553Z\n" msgid "Choose one or more dates..." msgstr "Choose one or more dates..." @@ -1071,9 +1071,6 @@ msgstr "Create new event" msgid "Search for a {{trackedEntityName}} in {{programName}}" msgstr "Search for a {{trackedEntityName}} in {{programName}}" -msgid "Back to list" -msgstr "Back to list" - msgid "No tracked entity types available" msgstr "No tracked entity types available" diff --git a/src/core_modules/capture-ui/NonBundledIcon/NonBundledIcon.component.js b/src/core_modules/capture-ui/NonBundledIcon/NonBundledIcon.component.js index dda968e42f..b906adcebb 100644 --- a/src/core_modules/capture-ui/NonBundledIcon/NonBundledIcon.component.js +++ b/src/core_modules/capture-ui/NonBundledIcon/NonBundledIcon.component.js @@ -27,7 +27,9 @@ export const NonBundledIcon = ({ {alternativeText} ) } From 02d5793322f4587a4f516d9463bf2df7faa6fd48 Mon Sep 17 00:00:00 2001 From: eirikhaugstulen Date: Mon, 14 Oct 2024 17:20:49 +0200 Subject: [PATCH 2/2] chore: fix failing tests --- cypress/e2e/MainPage/MainPage.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cypress/e2e/MainPage/MainPage.js b/cypress/e2e/MainPage/MainPage.js index a420c317b5..01a56c2777 100644 --- a/cypress/e2e/MainPage/MainPage.js +++ b/cypress/e2e/MainPage/MainPage.js @@ -1,4 +1,4 @@ -import { Given, Then, defineStep as And } from '@badeball/cypress-cucumber-preprocessor'; +import { defineStep as And, Given, Then } from '@badeball/cypress-cucumber-preprocessor'; Given('you are in the search page with Ngelehun and MNCH PNC context', () => { cy.visit('/#/search?orgUnitId=DiszpKrYNg8&programId=uy2gU8kT1jF'); @@ -20,13 +20,13 @@ And('you can load the view with the name Events assigned to me', () => { }); Then('the icon is rendered as a custom icon', () => { - cy.get('[alt="child_program_positive"]') + cy.get('[title="child_program_positive"]') .invoke('attr', 'src') .should('match', /\/icons\/child_program_positive\/icon$/); }); Then('the icon is rendered as an svg', () => { - cy.get('[alt="child_program_positive"]') + cy.get('[title="child_program_positive"]') .invoke('attr', 'src') .should('match', /\/icons\/child_program_positive\/icon.svg$/); });