Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclassing issues #58

Open
mamouneyya opened this issue Jun 12, 2016 · 2 comments
Open

Subclassing issues #58

mamouneyya opened this issue Jun 12, 2016 · 2 comments

Comments

@mamouneyya
Copy link

When subclassing the web browser view controller in Swift, the library seems to not access the resources anymore, making back / forward bar button images disappear.

@mamouneyya
Copy link
Author

mamouneyya commented Jun 12, 2016

After a quick digging in the code, I can see that in line 408 in KINWebBrowserViewController.m you get the class of the bundle using self, which won't work when subclassing. Explicitly specifying the class name solves the issue:
NSBundle *bundle = [NSBundle bundleForClass:[KINWebBrowserViewController class]];
instead of:
NSBundle *bundle = [NSBundle bundleForClass:[self class]];

I can make a PR for you if you're okay.

@wei
Copy link

wei commented Jun 15, 2016

Duplicate of #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants