Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DockerDesktopUrlUpdater #1317

Closed
3 of 4 tasks
hohwille opened this issue Aug 7, 2023 · 0 comments · Fixed by #1346
Closed
3 of 4 tasks

Fix DockerDesktopUrlUpdater #1317

hohwille opened this issue Aug 7, 2023 · 0 comments · Fixed by #1346
Assignees
@moritzLanger
Labels
enhancement New feature or request
Milestone
internal

Comments

@hohwille
Copy link
Member

hohwille commented Aug 7, 2023 •
edited by moritzLanger
Loading

We have implemented DockerDesktopUrlUpdater.
However, it has some issues and is not integrated in UpdateManager.
Manually we only have created one version for docker desktop pointing to the latest version:
https://github.com/devonfw/ide-urls/tree/master/docker/docker/latest

As discussed in #1293 this is not good and also prevents checksum verification.
So in this story we should do the following:

  • integrate DockerDesktopUrlUpdater into UpdateManager
  • run DockerDesktopUrlUpdater locally and test it.
  • if there are bugs (checksum errors, versions not detected, download URLs computed incorrect) we need to fix DockerDesktopUrlUpdater.
  • Then we can let the updater do its job and can manually delete the latest version from ide-urls for docker desktop.
@hohwille hohwille added the enhancement New feature or request label Aug 7, 2023
@hohwille hohwille mentioned this issue Aug 7, 2023
Open
@moritzLanger moritzLanger self-assigned this Aug 17, 2023
@CREITZ25 CREITZ25 mentioned this issue Aug 21, 2023
Closed
@moritzLanger moritzLanger mentioned this issue Sep 5, 2023
Merged
@moritzLanger moritzLanger linked a pull request Sep 5, 2023 that will close this issue
#1317 fix docker desktop url updater #1346
Merged
moritzLanger added a commit to moritzLanger/ide that referenced this issue Sep 5, 2023
@moritzLanger
devonfw#1317: fixed NullPointer
c3a1c8f
moritzLanger added a commit to moritzLanger/ide that referenced this issue Sep 5, 2023
@moritzLanger
devonfw#1317: reformated
cbd3b41
moritzLanger added a commit to moritzLanger/ide that referenced this issue Sep 5, 2023
@moritzLanger
devonfw#1317: arranged imports
bd526a7
moritzLanger added a commit to moritzLanger/ide that referenced this issue Sep 15, 2023
@moritzLanger
devonfw#1317 fixed regex comment
5ad70b2
@hohwille hohwille added this to the internal milestone Sep 17, 2023
hohwille pushed a commit that referenced this issue Sep 17, 2023
@moritzLanger
#1317: fix docker desktop url updater (#1346)
6f56d62
hohwille added a commit to devonfw/IDEasy that referenced this issue Sep 17, 2023
@hohwille
devonfw/ide#1317: fix docker desktop url updater (#1346)
723fc8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moritzLanger moritzLanger

Labels
enhancement New feature or request
Projects
None yet
Milestone
internal
Development

Successfully merging a pull request may close this issue.

#1317 fix docker desktop url updater moritzLanger/ide
2 participants
@hohwille @moritzLanger