Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SponsorLink Integration Makes Moq Unuasable due to PII and GDPR Requirements #1433

Closed
bleepzter opened this issue Oct 31, 2023 · 9 comments
Closed

Comments

@bleepzter
Copy link

Based on the comments of DinglDanglBob in the r/dotnet channel - it seems like "starting from version 4.20, does include a .NET analyzer that scans your local git config on build, gets your email address and sends it to some service hosted in Azure to check whether or not you're a sponsor."

This is unacceptable for medical, scientific, and financial organizations that work with PII (Personally Identifiable Information) and payment information and are regulated under PCI DSS, HIPPA, CCPA, or GDPR.

@bleepzter
Copy link
Author

It was closed long ago, but it still removes the library from the list of acceptable use OSS due to this issue. It can no longer be trusted.

@zarlo
Copy link

zarlo commented Nov 1, 2023

okay and what is your point making this issue?

@Laurianti
Copy link

6f3cf62

Has this change been released?

@kzu
Copy link
Member

kzu commented Dec 6, 2023

image

@kzu kzu closed this as completed Dec 6, 2023
@Laurianti
Copy link

image

Yes, it's finally resolved. Unlike v4.20.69, the issue is fixed in v4.20.70, which was released on November 28.

@edproton
Copy link

After the widespread adoption of NSubstitute, it became clear that efforts to monetize a popular and community-supported open source library could contribute to its decline. In essence, NSubstitute has now become the go-to choice for companies.

@Laurianti
Copy link

After the widespread adoption of NSubstitute, it became clear that efforts to monetize a popular and community-supported open source library could contribute to its decline. In essence, NSubstitute has now become the go-to choice for companies.

Why do you say this? Hasn't the issue been resolved? Are there still reasons not to use Moq today?

@MichaMican
Copy link

@Laurianti - it is not gone for good - it was first removed due to moq breaking on MacOS -> #1375

Also the big Discussion thread (#1374) doesn't change in a commitive end that this will not happen again. They just want to "find a better way" to do it with (hopefully) the feedback from the poll (#1414)

Even though it's fine now - there is no clear commitment of ditching the SponsorLink concept and only time will tell when and how it will return

@kzu
Copy link
Member

kzu commented Dec 18, 2023

It will not come back with any PII or GDPR issues. Please read about the new approach and provide feedback at devlooped/SponsorLink#100

@devlooped devlooped locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants