Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to mark reactions as "seen" #6210

Open
iequidoo opened this issue Nov 15, 2024 · 0 comments
Open

Make it possible to mark reactions as "seen" #6210

iequidoo opened this issue Nov 15, 2024 · 0 comments

Comments

@iequidoo
Copy link
Collaborator

There is https://github.com/deltachat/deltachat-android/pull/3377 which adds notifications for reactions. But it's blocked because when the user receives a reaction notification on multiple devices and clicks "Mark read" on one device (or, equivalently, enters the chat), then the notification won't be removed from the other devices.
This should be fixed by remembering the rfc724_mid of reaction emails and marking them as seen on the server just as normal messages. Then, the second device can notice that they were marked as seen and send a MsgsNoticed event. I started implementing this in hoc/reaction-notifications-2, but got distracted (I didn't get very far, just half an hour or so, and I don't even know whether the approach I started with was the right one).

I've taken a look at this, but for me it seems simpler to add reactions as hidden=1 messages to the msgs table as well, then the existing mechanism of "marking seen" works for them. Also this allows to have Param::OverrideSenderDisplayname for reactions which may be useful for bridge bots, that was mentioned in the closed #5184. Currently reactions just go to the trash chat. Not sure if this is actually simpler because many changes to tests may be needed. CC @Hocuri @r10s @hpk42 @link2xt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant