Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vg-request-with-auth from IMAP after processing #6208

Open
link2xt opened this issue Nov 14, 2024 · 1 comment
Open

Remove vg-request-with-auth from IMAP after processing #6208

link2xt opened this issue Nov 14, 2024 · 1 comment

Comments

@link2xt
Copy link
Collaborator

link2xt commented Nov 14, 2024

Alice currently does not remove the message from IMAP for some reason stated in the comment:

Ok(HandshakeMessage::Ignore) // "Done" would delete the message and break multi-device (the key from Autocrypt-header is needed)

In multi-device case this may result in situation when Bob join the group, then leaves it, then second Alice device comes online and processes vg-request-with-auth again and adds Bob back.

I don't see why Autocrypt header is needed by the second device, Alice should see self-sent "member added" message and take gossiped Bob's key from there.

This is a follow-up to #5356

@iequidoo
Copy link
Collaborator

I don't see why Autocrypt header is needed by the second device

Probably because it's a common code for the "verified groups" and "verified contacts" setup protocols. Yes, it seems that vg-request-with-auth may be safely IMAP-removed, but we should make sure that gossiping happens even in case of two-member groups and add a test for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants