You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ok(HandshakeMessage::Ignore)// "Done" would delete the message and break multi-device (the key from Autocrypt-header is needed)
In multi-device case this may result in situation when Bob join the group, then leaves it, then second Alice device comes online and processes vg-request-with-auth again and adds Bob back.
I don't see why Autocrypt header is needed by the second device, Alice should see self-sent "member added" message and take gossiped Bob's key from there.
I don't see why Autocrypt header is needed by the second device
Probably because it's a common code for the "verified groups" and "verified contacts" setup protocols. Yes, it seems that vg-request-with-auth may be safely IMAP-removed, but we should make sure that gossiping happens even in case of two-member groups and add a test for that.
Alice currently does not remove the message from IMAP for some reason stated in the comment:
deltachat-core-rust/src/securejoin.rs
Line 473 in e7a29f0
In multi-device case this may result in situation when Bob join the group, then leaves it, then second Alice device comes online and processes
vg-request-with-auth
again and adds Bob back.I don't see why Autocrypt header is needed by the second device, Alice should see self-sent "member added" message and take gossiped Bob's key from there.
This is a follow-up to #5356
The text was updated successfully, but these errors were encountered: