Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Compatible with xrdb values (Xresources colors) #1992

Open
2 tasks done
Angel-Karasu opened this issue Jun 26, 2024 · 3 comments
Open
2 tasks done

[REQUEST] Compatible with xrdb values (Xresources colors) #1992

Angel-Karasu opened this issue Jun 26, 2024 · 3 comments

Comments

@Angel-Karasu
Copy link

Angel-Karasu commented Jun 26, 2024

Before opening a feature request

  • I checked the next branch to see if the feature has already been implemented
  • I searched existing reports to see if it is already requested.

What is the user problem or growth opportunity you want to see solved?

The user can't use xrdb setted values (in the Xresources file)

How do you know that this problem exists today? Why is this important?

Because I can't use my xrdb setted values

Who will benefit from it?

For all users that have configure colors or any others value in Xresources file

Rofi version (rofi -v)

1.7.5

Configuration

https://github.com/Angel-Karasu/dotfiles/blob/main/config/rofi/config.rasi

Additional information

The format can be:

mycolor: ${xrdb:name};

With ${xrdb:name} that use the value return by xrdb -get name.

For example, for me xrdb -get background return #121212 that I want to set this color in mycolor.

I'm willing to help implement it but I haven't managed to understand how the parser works.

@DaveDavenport
Copy link
Collaborator

something like this would be kinda ok to me, but it might not be handy for @lbonn wayland port.

@Angel-Karasu
Copy link
Author

Angel-Karasu commented Jun 27, 2024

Normally xrdb -get name it's also available on Wayland (it works for me in VM on qtile wayland with EndeavourOS)

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Jun 27, 2024

Yeah, but that uses xwayland I assume.
If this would be implemented, it should be done via libxcb library (as done in very old versions of rofi), this would be difficult in wayland port as I don't think that has it, or access to the required underlying interface.

I don't think it is good to have it depend on both.

You could always wrap rofi and set environment variables for colors, this you can use in themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants