Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependency management tasks more explicit #1133

Open
christian-weiss opened this issue Jan 17, 2024 · 0 comments
Open

Make dependency management tasks more explicit #1133

christian-weiss opened this issue Jan 17, 2024 · 0 comments

Comments

@christian-weiss
Copy link
Contributor

On a fresh git clone + yarn install a new developer will get the following list of yarn warnings.

warning " > [email protected]" has unmet peer dependency "algoliasearch@>= 3.1 < 5".
warning " > [email protected]" has unmet peer dependency "react@>= 16.3.0 < 19".
warning " > [email protected]" has unmet peer dependency "react-dom@>= 16.3.0 < 19".
warning "react-instantsearch-dom > [email protected]" has unmet peer dependency "algoliasearch@>= 3.1 < 5".
warning "react-instantsearch-dom > [email protected]" has unmet peer dependency "algoliasearch@>= 3.1 < 5".
warning "react-instantsearch-dom > [email protected]" has unmet peer dependency "react@>= 16.3.0 < 19".
warning " > [email protected]" has unmet peer dependency "react@>=0.14.0".
warning " > [email protected]" has unmet peer dependency "react-dom@>=0.14.0".
warning " > @this-dot/[email protected]" has incorrect peer dependency "cypress@< 12.6.0".
warning " > [email protected]" has incorrect peer dependency "eslint@^4.0.0 || ^5.0.0".
warning " > [email protected]" has incorrect peer dependency "postcss@^8.4.14".
warning " > [email protected]" has incorrect peer dependency "webpack@^5.0.0".
warning " > [email protected]" has incorrect peer dependency "stylelint@^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0".
warning " > [email protected]" has incorrect peer dependency "stylelint@10 - 13".

Currently it is not documented in this project what the current assessment of this team is:

  • if it is safe to ignore this or
  • if one should act and improve the project.

In addition to that new issues should bring the CI/CD pipeline to fail:

  • to trigger an assessment,
  • let team mates fix it or
  • to document the reason why it is safe to ignore this warning/error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant