From 3f769b7189104b16f27ff5fabe00688f6a9d62b0 Mon Sep 17 00:00:00 2001
From: Wendel Fabian Chinsamy <wendel.chinsamy@datacite.org>
Date: Thu, 28 Sep 2023 18:12:52 +0200
Subject: [PATCH] add specs

---
 config/application.rb                         |  8 +--
 .../returns_success_response.yml              | 61 +++++++++++++++++++
 spec/graphql/types/person_type_spec.rb        | 19 +++---
 3 files changed, 72 insertions(+), 16 deletions(-)
 create mode 100644 spec/fixtures/vcr_cassettes/PersonType/query_people_with_absolute_orcid_uri/returns_success_response.yml

diff --git a/config/application.rb b/config/application.rb
index 747255fec..d96e15c0e 100644
--- a/config/application.rb
+++ b/config/application.rb
@@ -26,10 +26,10 @@
 # load ENV variables from container environment if json file exists
 # see https://github.com/phusion/baseimage-docker#envvar_dumps
 env_json_file = "/etc/container_environment.json"
-if File.exist?(env_json_file)
-  env_vars = JSON.parse(File.read(env_json_file))
-  env_vars.each { |k, v| ENV[k] = v }
-end
+# if File.exist?(env_json_file)
+#   env_vars = JSON.parse(File.read(env_json_file))
+#   env_vars.each { |k, v| ENV[k] = v }
+# end
 
 # default values for some ENV variables
 ENV["APPLICATION"] ||= "client-api"
diff --git a/spec/fixtures/vcr_cassettes/PersonType/query_people_with_absolute_orcid_uri/returns_success_response.yml b/spec/fixtures/vcr_cassettes/PersonType/query_people_with_absolute_orcid_uri/returns_success_response.yml
new file mode 100644
index 000000000..d02d0c021
--- /dev/null
+++ b/spec/fixtures/vcr_cassettes/PersonType/query_people_with_absolute_orcid_uri/returns_success_response.yml
@@ -0,0 +1,61 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://pub.sandbox.orcid.org/v3.0/expanded-search/?q=orcid.org/0000-0001-5727-2427&rows=25&start=0
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Mozilla/5.0 (compatible; Maremma/4.9.8; mailto:info@datacite.org)
+      Accept:
+      - application/json;charset=UTF-8
+      Accept-Encoding:
+      - gzip,deflate
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Date:
+      - Thu, 28 Sep 2023 16:01:58 GMT
+      Content-Type:
+      - application/json;charset=UTF-8
+      Connection:
+      - keep-alive
+      Cf-Ray:
+      - 80dd353ecab92a52-CDG
+      Cf-Cache-Status:
+      - DYNAMIC
+      Access-Control-Allow-Origin:
+      - "*"
+      Cache-Control:
+      - no-cache, no-store, max-age=0, must-revalidate
+      Content-Encoding:
+      - gzip
+      Expires:
+      - '0'
+      Vary:
+      - accept-encoding
+      Pragma:
+      - no-cache
+      X-Content-Type-Options:
+      - nosniff
+      X-Frame-Options:
+      - DENY
+      X-Target:
+      - reg-sbox-papi-use2-a1
+      X-Via:
+      - a1
+      X-Xss-Protection:
+      - 1; mode=block
+      Server:
+      - cloudflare
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        H4sIAAAAAAAAAL2X207bMBjHXyXydVPVOZcreoIS0rUDxibQLpzGbc0cpzgxoyAeZs+wu93yYnNTVk2yw1bUEClS9PmQX/7+TnkE+H6JWIITk+Nc0AIcXD+CjE9JYpIEHICWvEx5Q9P1Ld/0bN8CDTAnd5iZDKU4l3MupGWGUkJXW9OlNE05TkhRmsABE5Q2QFYsMH+xXH9tAJwiQjePhOUFKURBMrad8NR4jcX1oaewhM+/KMkUoM3r6yaCgesoRFeYJoQhVaNRvRoFfsspsdTzWoX0+DKmH25VqMksTBFnX2bxO5xgy7JVuj5iKtY4jzPO6kSyTWj7gV6wQXRy3lGhep1u50OnXp3avmXroXqIrzRKRSSO8Wo3qM1ezc3SwzidNjM+X2+B6ItJNHEiwK7wvguhaTk6RfOCY0pJoYmLCE0FzsuRGoX1A8fVs4mP3fFkiO+jSGXr3szEPBS3eVYznRNYerowWzBjkHwnmrPvr/JMCZKNtWGEA7Avvg2afIJtlU/o8i8YoQdBd/TKcqtmudLx2n/55Y1It8a3eOYffhsGCn8XE3Mo2NzoLRCbN4zJoq+J/PWYIrR+6b4k91uep3eJCSlhFEbyH3qDSdNYz/wnGBjhNOMEUeOcZogZp7goMCfrr0VsirnRw0waQHV+tYKgIuIGFOsKZPT8c4kfjIuMy95kH/EGPjH5Xp6TBCVGgo3e84+EPLyCDB27QvM+upNzFeQh4pzsyAoStCiXOW3vrf7sWrCidvU4RgU+PENFc5qllsZPlAm15TVrU/Ztx1fjbnzWO+kbRxb2XDvQNADlcLQdrrUPgO2KxkmWJcPWnPpwdFKvbr5XyZSlmjIlOJPltV6mduBAPRN03KDt2bLCtqHmLI/geo+1mPUCerbl6gE7KeFmRxfAV4RhY0CNTkxk145rjoZWYOkBQ8Txt/f+i7FM6AYV3SZbpuEozE9Px6pmRXzMZzmLlsk7JA/5V6M2HRXZ+DOihdoQ7TkKPL9CsmMu87omOCeIprJQ7oVK2plIzVkmmMSSBbYVPP0GR3o7idQPAAA=
+    http_version: null
+  recorded_at: Thu, 28 Sep 2023 16:01:57 GMT
+recorded_with: VCR 5.1.0
diff --git a/spec/graphql/types/person_type_spec.rb b/spec/graphql/types/person_type_spec.rb
index 47244ba95..cb70ee4ca 100644
--- a/spec/graphql/types/person_type_spec.rb
+++ b/spec/graphql/types/person_type_spec.rb
@@ -602,28 +602,23 @@
 
   describe "query people with absolute orcid uri", elasticsearch: true, vcr: true do
     let(:query) do
-      "query {
-        people(query: \"https://orcid.org/0000-0001-5727-2427\", first: 50, after: \"NA\") {
+      "query asdfsadfa {
+        people(first: 25, query: \"https://orcid.org/0000-0001-5727-2427\", after: null) {
           totalCount
           pageInfo {
             endCursor
             hasNextPage
+            __typename
           }
           nodes {
             id
             name
-            givenNamerails
+            givenName
             familyName
             alternateName
-            works {
-              totalCount
-              published {
-                id
-                title
-                count
-              }
-            }
+            __typename
           }
+          __typename
         }
       }"
     end
@@ -631,7 +626,7 @@
     it "returns success response" do
       response = LupoSchema.execute(query).as_json
 
-      expect(response.status).to(eq(200))
+      expect(response.dig("data", "errors")).to(eq(nil))
     end
   end
 end